Repository navigation
fix(evals): stop at startup when the eval model provider is missing - #119
Merged
chrisohearn merged 1 commit intoNov 14, 2026
Merged
Conversation
The proxy-backed evals (mcp-tool-use with Codex models, test-signal) crashed with a Python KeyError traceback when ~/.codex/config.toml had no `vibeproxy` provider. They now exit 2 with one message naming the missing provider and the config path, and saying evals are optional and paid. The config is read from $CODEX_HOME when set. FORK.md and evals/README.md record that on this fork hosted CI, the agent context budget check and the review of record gate model-facing text changes; paid eval runs need the owner's go-ahead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
chrisohearn
merged commit Nov 14, 2026
7e4afd5
into
integration/mcp-events-20261109
18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proxy-backed evals (
mcp-tool-usewith Codex models, andtest-signal) crashed with a PythonKeyError: 'vibeproxy'traceback when~/.codex/config.tomlhad novibeproxyprovider. The traceback didn't say what was missing or that evals are optional.Fix
evals/shared/proxy.ts: the TOML reader exits with a sentinel code when the config file, themodel_providerstable, or thevibeproxyentry is missing.readProxyConfigturns that into aProxyConfigMissingerror.proxyConfig(), which both evals call before any model request, prints that error's message and exits 2, without a stack trace. The Codex home is read from$CODEX_HOMEwhen set, otherwise~/.codex.evals/shared/proxy.test.ts: covers the three missing cases and a configured provider (the control case).FORK.md(new "Evals" section) andevals/README.md: on this fork, hosted CI, theAgent context budgetcheck and the review of record gate model-facing text changes. Paid eval runs need the owner's go-ahead for each run.No new feature. No eval or model call was run.
Acceptance checks
vibeproxyprovider configured,node test-signal/run.ts --out <tmp>prints the following and exits 2, without creating any output:node mcp-tool-use/run.ts --model gpt-6-astra --case review-round-uses-thread-send --samples 1 --out <tmp>prints the same message and exits 2 before any model call.vp test run --config ../vite.config.ts shared/proxy.test.ts --maxWorkers=2 --no-file-parallelism(fromevals/): 4 passed.effect-tsgo tsrs --noEmitinevals/: exit 0, no errors.vp fmt --checkandvp linton the changed files, plus the pre-commit hook's fmt, lint andknip:check: pass.The broad local
check:changedwas not run: on the shared host it ran out of memory. CI runs the full suites.Model and harness: Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code