Repository navigation
Merge upstream main (95cb068c10) - #99
Conversation
…preparing tile (pingdotgg#35265) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…l the model lacks (pingdotgg#35432)
…st their pin (pingdotgg#21249) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Yash Singh <saiansh2525@gmail.com>
…livered, not failed (pingdotgg#35463)
… offers Show all projects (pingdotgg#35426)
…s an IME candidate (pingdotgg#35468)
… hidden-thread count (pingdotgg#35499)
…ingdotgg#35502) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… an agent started (pingdotgg#35405) Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-authored-by: David Preil <dzpreil@gmail.com> Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… pass (pingdotgg#26935) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#35783) * feat(mobile): secret field gets an eye toggle to show what you typed
…t frame (pingdotgg#35683) Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
… into sync/upstream-20261113-0321
… into sync/upstream-20261113-0321 # Conflicts: # apps/server/src/provider/agentContextBudget.json
… into sync/upstream-20261113-0321
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
… into sync/upstream-20261113-0321
Independent fallback review: #99, "Merge upstream main (95cb068)"Reviewer: Claude Opus 5.5, read-only. This is the review of record for code and security because the hosted Codex review hit its usage limit.
Identity checks (git and gh):
Verdicts
Findings1. Low: a run with only fork migrations pending logs the "migrations started" marker but never the "finished" marker.
2. Informational: clients that negotiate MCP 2026-07-28 do not get the fork's events extension.
3. Informational: the model-facing description of
What I verifiedMigration namespace
Fork preservation
Notes on specific files:
Packaging
Security boundaries
Hosted state (status only; not used as review evidence)
Coverage and limitations
|
Reconciliation of the independent reviewFinding 1 is genuine and fixed in The existing Proof:
Informational notes remain bounded: legacy initialization keeps fork events, the 2026-07-28 discovery adapter does not advertise events, and actual Jarvis negotiation/outage was not demonstrated. Modern compatibility is retained. No live event-wake acceptance or paid model-behavior eval pass is claimed. A recovered review of A fresh independent exact-head code/security review and latest-head CI remain required. The explicit publication hold covering integration #96/#100 ancestry and the independent service rollout hold both remain in force. Passing this repair does not clear them. No publishing wrapper, merge, release, install, deployment or acknowledge-only activation has occurred. |
Exact-head fallback code and security review: #99 (final-head recheck)Reviewer: Claude Opus 5.5 (
Identity, checked once:
Commits since the prior review:
Verdicts
This verdict covers the code only. It does not clear either control that is still in force: the maintainer's publication and custody hold on #96/#100 ancestry, and the separate kernel/cgroup hold on automatic updates. This review grants no authority to merge, publish, release, deploy or turn on acknowledge-only. Disposition of the migration findingPrior finding 1 (Low): a run with only fork migrations pending logged the "started" marker and never the "finished" marker. It is fixed. The fix:
Every way the started marker can be logged now ends with the finished marker on a full run. The started marker is logged when
The case not covered can't happen in production. A partial run ( The fork's own log line does not count as the finished marker, so the fix is needed. One cosmetic note: a run with only fork work logs the finished line with The regression test is good. It is in
Migration namespace (FORK.md)
Merging the integration branch (
|
Exact-head fallback code and security review: #99 (integration re-merge, final head)Reviewer: Claude Opus 5.5 (
Identity, checked read-only (no fetch, no ref changes):
Commits since the previous review:
Verdicts
Gate condition: this approval assumes the final-tree
This verdict covers the code only. It grants no authority to push, merge, publish, release, deploy or turn on acknowledge-only. Those controls stay with the coordinator. Finding 1 (Medium, fixed in
|
|
Daily upstream sync: merges Format, lint, typecheck, server tests, the container release build with its smoke test, and the service preflight against the live database passed. Prepared release candidate 🤖 Generated with Claude Code |
dc3ee55
into
integration/mcp-events-20261109
Scope
Finish the existing upstream-sync candidate through
pingdotgg/t3codemain95cb068c10a6cf0b33eed0a0cab3b298763fe852, before adding newer upstream commits. Candidate0537f39fff2561b2465872c8a2021b397a59240fmerges current fork integration782fe7fa606df2f3ae88e0540bf43b2700f8ed04.Preserves fork MCP/events, orchestration, thread freeze, scheduled-model and snooze behavior, agent registry, and fork-only migration history in
t3_fork_migrations. Fork migration files and registry match integration; upstream migration files match the selected upstream cutoff. The contract merge preserves both upstream title-regeneration state and fork scheduled-model state. The MCP tool-list budget is remeasured at 58,309 bytes.Repairs
3803fc0fb7: combine the SEA Undici and upstream JSONC aliases instead of letting the later alias object overwrite the first. The packaging regression fails before the fix and all 13 packaging tests pass afterward.01a98a8397: emit the shared migration-finished marker after fork-only migration execution or legacy-history repair. The existing regression exercises both paths through the actual desktop output parser and asserts the separate migration histories. Both assertions fail before the product fix and pass afterward.ef46659388: correct the regression logger's message typing after the integrated gate exposedTS2488. No failing check is waived.147b9691ac: merge the current integration branch without adding newer upstream commits; preserve both contract additions and remeasure the context budget.0537f39fff: supply upstream's required provider-config hydration dependency in the newly merged terminal test table. A focused retry reproduced all three failures andTS2741; after the one-line fixture repair all 89 terminal tests and direct server typecheck pass.Verification
0537f39fffvp run check:changed origin/integration/mcp-events-20261109 --concurrency 1passes: all 41 affected package typechecks, 345 test files / 8,678 tests (1 skipped), 26 node tests, format, lint, both knip checks, generated GraphQL and React compiler checks. The additional cross-file test pass reports 227 passing tests.ef46659388gate passed: all 41 affected package typechecks, 345 test files / 8,664 tests (1 skipped), 26 node tests, format, lint, knip, generated GraphQL and React compiler checks. This is historical evidence, not a waiver for the refreshed head.Review And Release Gates
Hosted Codex review failed on its usage limit and is not requested again. The independent exact-ef466 code/security review approves the earlier tree and confirms the migration repair. The independent exact-head code/security review of
0537f39fff2561b2465872c8a2021b397a59240fagainst782fe7fa606df2f3ae88e0540bf43b2700f8ed04is complete: both APPROVE. It covers the integration delta, terminal fixture repair and merge interactions while reusing unchanged review evidence. Its final-tree check condition is satisfied. Final-head hosted checks completed with 19 successes and 2 workflow-selected mobile skips; there were no review threads, unresolved findings or running latest-head reviews at merge.The maintainer's PR96/100 ancestry-publication and automatic-update holds have been cleared by the owning coordinator. This does not substitute for source, CI, review, release-build or deployment verification. Acknowledge-only activation remains separately owned and is not part of this work. The kernel issue is not claimed fixed.
The mandatory
t3-sync-upstreamwrapper exited 0 after full format/lint/typecheck checks, 8,253 passing server tests (5 skipped), the container release build and runtime smoke test, and ready read-only live-database preflights for launcher protocols 3 and 4. The PR merged asdc3ee559385459a00ff1086e1419802a8f618fcfat 2026-11-13T19:22:25Z and v0.1.10-preview.20261113.4 was published at 19:24:14Z. The candidate, merge, integration tip and release tag share verified tree8b64c6393a45f4805019ec7ecec0947cb24f9db4. The Linux archive andSHA256SUMSare present; the archive's GitHub SHA256 digest matches the published checksum (0434d8ab481d1ac8cab9782993be9acc988c4942b94eb998e19b0250a2d4f17c).Publication is not live deployment. A normal
t3-service-updateattempt deferred for 4 active threads; the existing guarded idle/three-hour-cap timer remains responsible. No--nowor interrupting deployment was used. As of 19:25Z,0.1.10-preview.20261113.3still serves, trusted/healthy under launcher protocol 4, with upstream migration 85, fork migration 15 and zero namespace-name collisions. Local/Tailscale serving probes and T3 Connect reachability passed. The next maintenance run must verify.4serving, guard health, launcher protocol, migration histories and both remote routes before claiming it live.The MCP 2026-07-28 events-capability seam remains an informational compatibility note, not a proven live outage. Modern protocol support is retained. Paid model-behavior evals and live Jarvis event-wake acceptance have not been run and are not claimed passing.
Related #89; newer upstream remains for the next candidate.
Prepared by Codex in Codex CLI for the authorized hourly fork-maintenance task.