Repository navigation
Conversation
Releasing from main took a hand-made prepare-release PR and a manual tag, and each step was a chance to slip. release-plz now opens and maintains that PR after every push to main, bumping the workspace version from conventional commits since the last v* tag. The configuration differs from other CipherStash repos on purpose, recorded in docs/adr/0001: versions come from git tags (nothing goes to crates.io), the changelog stays hand-written, semver checks are off because the library target is internal, and the job uses a GitHub App token from the main-only `release` environment so the release PR runs the required CI. git_only is set on cipherstash-proxy rather than the workspace: workspace-wide, release-plz looks up every member at the last tag and fails on members added since then. A local dry run of release-plz 0.3.174 with this config proposes 3.0.1 -> 3.1.0 and changes only Cargo.toml and Cargo.lock. The 2.2.x tags don't interfere, because release-plz takes the highest matching semver tag. Tagging and the GitHub release stay manual (`mise run release`) until the release step is added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tobyhede
marked this pull request as ready for review
November 9, 2026 01:31
cipherstash-agent
left a comment
cipherstash-agent
left a comment
There was a problem hiding this comment.
Review attestation
Reviewed b2d6059 · posted from Claude Code · claude-sonnet-5-5 · effort medium
Sources: code-review · unknown model (forked skill run); review-cross-check · claude-sonnet-5-5
Skills: code-review, review-cross-check, review-post
No findings.
Generated by Claude Code
The client ID is stored as a secret in the release environment, not a variable, so vars.RELEASE_PLZ_APP_CLIENT_ID would be empty and the token step would fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #503 (the
Release metadatacheck). Merge that first; GitHub will then retarget this PR tomain.Summary
Releasing from main took a hand-made prepare-release PR and a manual tag, and each step was a chance to slip.
release-plz now opens and maintains that PR after every push to main, bumping the workspace version from the conventional commits since the last
v*tag.Merging the release PR is the human gate before production.
Changes
release-plz.toml: versions come fromv*git tags (git_onlyoncipherstash-proxyonly), nothing is published, onlycipherstash-proxyis released, the changelog stays hand-written, semver checks are off, tags arevX.Y.Z..github/workflows/release-plz.yml: runsrelease-plz release-pron push to main with a GitHub App token from the main-onlyreleaseenvironment, so the release PR runstest.ymland the requiredBuild (Rust MSRV)check. Actions are pinned to SHAs, default permissions arecontents: read, and runs are never cancelled mid-way.docs/adr/0001-release-plz-release-pr.md: why the setup looks like this and how it differs from cipherstash/stack.DEVELOPMENT.md: the prepare-release step now describes the release PR. release/2.2 keeps the manual steps.Tagging and the GitHub release stay manual (
mise run release) until a follow-up adds the release step with signed tags.Verification
3.0.1 -> 3.1.0and changes onlyCargo.tomlandCargo.lock. The 2.2.x tags don't interfere, because release-plz takes the highest matching semver tag.git_onlyfailed oncipherstash-proxy-burn-in(added after v3.0.1), and semver checks on the internal library would have forced major bumps.test.ymlruns on it, and a second push to main updates the same PR.Review notes
RELEASE_PLZ_APP_CLIENT_IDandRELEASE_PLZ_APP_PRIVATE_KEYas secrets from thereleaseenvironment.Acknowledgment
By submitting this pull request, I confirm that CipherStash can use, modify, copy, and redistribute this contribution, under the terms of CipherStash's choice.
Generated by Claude Code