Skip to content

feat(stack-kms-aws): AWS KMS key vendor backend (CIP-5307) - #1527

Closed
freshtonic wants to merge 1 commit into
james/cip-5306-keyset-records-the-two-key-modes-and-the-static-key-backendfrom
james/cip-5307-aws-kms-key-vendor-backend-stack-kms-aws
Closed

freshtonic wants to merge 1 commit into
james/cip-5306-keyset-records-the-two-key-modes-and-the-static-key-backendfrom
james/cip-5307-aws-kms-key-vendor-backend-stack-kms-aws

Conversation

@freshtonic

@freshtonic freshtonic commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Layer 4 of the CIP-5203 stack. Implements CIP-5307 (ADR-0014).

  • New crate stack-kms-aws: a hand-written AWS KMS JSON client with in-crate SigV4 (no aws-sdk). It wraps the root key with Encrypt and unwraps it with Decrypt. The AAD is bound through EncryptionContext.
  • Credentials: static and environment, IRSA, the ECS container endpoint, and IMDSv2 (native only), cached and refreshed before expiry.
  • HttpVendorTransport (native, in stack-kms-vendor).
  • Tests: SigV4 vectors, recorded fixtures, the contract suite, and a LocalStack job that runs on PRs.
  • The crate is staged for crates.io, with release = false.

Decisions are in docs/plans/2026-11-05-key-vendor-backends-decisions.md (CIP-5307 sections).

@freshtonic
freshtonic added this pull request to stack #1523 November 5, 2026 23:40
@freshtonic freshtonic changed the title james/cip 5307 aws kms key vendor backend stack kms aws feat(stack-kms-aws): AWS KMS key vendor backend (CIP-5307) Nov 5, 2026
@changeset-bot

changeset-bot Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f07f74a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Mutation testing (cargo-mutants, --in-diff, stack-auth + stack-encrypt)

No mutants were generated for the changed lines.

@freshtonic
freshtonic force-pushed the james/cip-5307-aws-kms-key-vendor-backend-stack-kms-aws branch 2 times, most recently from 8d2579a to 14f5bdd Compare November 6, 2026 05:10
@freshtonic
freshtonic force-pushed the james/cip-5306-keyset-records-the-two-key-modes-and-the-static-key-backend branch from a4009c2 to 11819bf Compare November 6, 2026 05:10
@freshtonic
freshtonic force-pushed the james/cip-5307-aws-kms-key-vendor-backend-stack-kms-aws branch from 089a740 to ee3980e Compare November 9, 2026 04:16
@freshtonic
freshtonic removed this pull request from stack #1523 November 9, 2026 04:17
@freshtonic
freshtonic added this pull request to stack #1579 November 9, 2026 04:17
@freshtonic
freshtonic force-pushed the james/cip-5307-aws-kms-key-vendor-backend-stack-kms-aws branch from ee3980e to f9afbdf Compare November 10, 2026 02:37
@freshtonic
freshtonic force-pushed the james/cip-5306-keyset-records-the-two-key-modes-and-the-static-key-backend branch from 376712b to 11ca7f3 Compare November 12, 2026 03:44
@freshtonic
freshtonic force-pushed the james/cip-5307-aws-kms-key-vendor-backend-stack-kms-aws branch from f9afbdf to 677cc5a Compare November 12, 2026 03:44
@freshtonic
freshtonic removed this pull request from stack #1579 November 12, 2026 03:45
@freshtonic
freshtonic added this pull request to stack #1623 November 12, 2026 03:47
@freshtonic

Copy link
Copy Markdown
Contributor Author

Scope reduced (2026-11-12). This branch was rebuilt from one final tree by path, and the follow-up PRs #1555 to #1563 were folded in. The plan is docs/plans/2026-11-12-key-vendor-backends-scope-reduction.md; the decision log's "Scope reduction" section records each change. Decisions: no stack-encrypt change, no v2 leaf, and the wrapped data key mode deferred.

In this PR: no GenerateDataKey, and no cipherstash:descriptor in the encryption context. The fixtures were brought up to date with the record AAD. The LocalStack test passed locally.

@freshtonic
freshtonic force-pushed the james/cip-5307-aws-kms-key-vendor-backend-stack-kms-aws branch from 677cc5a to f07f74a Compare November 12, 2026 05:24
@freshtonic
freshtonic removed this pull request from stack #1623 November 12, 2026 05:28
@freshtonic

Copy link
Copy Markdown
Contributor Author

Replaced by #1626, in the new stack #1633. The code is the same, rebased onto the latest next. The ADRs are now ADR-0013 and ADR-0014, and the text about the wrapped data key mode is removed.

@freshtonic freshtonic closed this Nov 12, 2026
@freshtonic
freshtonic deleted the james/cip-5307-aws-kms-key-vendor-backend-stack-kms-aws branch November 12, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant