Skip to content

feat(stack-kms-gcp): Google Cloud KMS key vendor backend (CIP-5308) - #1530

Closed
freshtonic wants to merge 1 commit into
james/cip-5310-hashicorp-vault-transit-key-vendor-backend-stack-kms-vaultfrom
james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcp
Closed

freshtonic wants to merge 1 commit into
james/cip-5310-hashicorp-vault-transit-key-vendor-backend-stack-kms-vaultfrom
james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcp

Conversation

@freshtonic

@freshtonic freshtonic commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Layer 6 of the CIP-5203 stack. Implements CIP-5308.

  • New crate stack-kms-gcp: a Cloud KMS REST client (encrypt/decrypt) that supports both key modes. Data keys are generated locally, the AAD goes in additionalAuthenticatedData, and CRC32C is checked on every field.
  • Credentials: a static token, a service account JWT (RS256 with the rsa crate), and the metadata server (native only).
  • Tests: hand-written fixtures, a JWT known-answer test against openssl, and the contract suite.
  • The opt-in live workflow is integration-gcp-kms.yml. To turn it on, set the variable STACK_KMS_GCP_LIVE_KEY and the secret STACK_KMS_GCP_SERVICE_ACCOUNT_KEY.
  • Before release: a security reviewer must sign off on RUSTSEC-2023-0071 (rsa). See the orchestrator review in the decision log.

@freshtonic
freshtonic added this pull request to stack #1523 November 6, 2026 00:26
@freshtonic freshtonic changed the title james/cip 5308 google cloud kms key vendor backend stack kms gcp feat(stack-kms-gcp): Google Cloud KMS key vendor backend (CIP-5308) Nov 6, 2026
@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

@changeset-bot

changeset-bot Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: bd27363

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Mutation testing (cargo-mutants, --in-diff, stack-auth + stack-encrypt)

No mutants were generated for the changed lines.

@freshtonic
freshtonic force-pushed the james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcp branch from 1d6b20b to fb22d06 Compare November 6, 2026 02:15
@freshtonic
freshtonic force-pushed the james/cip-5310-hashicorp-vault-transit-key-vendor-backend-stack-kms-vault branch 2 times, most recently from bfdd74a to 95da1a1 Compare November 6, 2026 05:10
@freshtonic
freshtonic force-pushed the james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcp branch 2 times, most recently from 73a5153 to 5663ebf Compare November 6, 2026 05:13
@freshtonic
freshtonic force-pushed the james/cip-5310-hashicorp-vault-transit-key-vendor-backend-stack-kms-vault branch 2 times, most recently from 0642192 to 3dd5da9 Compare November 9, 2026 04:16
@freshtonic
freshtonic force-pushed the james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcp branch from 5663ebf to 24ee92a Compare November 9, 2026 04:16
@freshtonic
freshtonic removed this pull request from stack #1523 November 9, 2026 04:17
@freshtonic
freshtonic added this pull request to stack #1579 November 9, 2026 04:17
@freshtonic
freshtonic force-pushed the james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcp branch from 24ee92a to a5f115d Compare November 10, 2026 02:37
@freshtonic
freshtonic force-pushed the james/cip-5310-hashicorp-vault-transit-key-vendor-backend-stack-kms-vault branch from 3dd5da9 to 447acd9 Compare November 10, 2026 02:37
@freshtonic
freshtonic force-pushed the james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcp branch from a5f115d to fced2d9 Compare November 12, 2026 03:44
@freshtonic
freshtonic force-pushed the james/cip-5310-hashicorp-vault-transit-key-vendor-backend-stack-kms-vault branch from 447acd9 to f9b71cc Compare November 12, 2026 03:44
@freshtonic
freshtonic removed this pull request from stack #1579 November 12, 2026 03:45
@freshtonic
freshtonic added this pull request to stack #1623 November 12, 2026 03:47
@freshtonic

Copy link
Copy Markdown
Contributor Author

Scope reduced (2026-11-12). This branch was rebuilt from one final tree by path, and the follow-up PRs #1555 to #1563 were folded in. The plan is docs/plans/2026-11-12-key-vendor-backends-scope-reduction.md; the decision log's "Scope reduction" section records each change. Decisions: no stack-encrypt change, no v2 leaf, and the wrapped data key mode deferred.

In this PR: no same_key. The AAD fixtures were computed again by a separate script. This PR now also brings _test-kms-live.yml (#1556).

@freshtonic
freshtonic force-pushed the james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcp branch from fced2d9 to bd27363 Compare November 12, 2026 05:24
@freshtonic
freshtonic force-pushed the james/cip-5310-hashicorp-vault-transit-key-vendor-backend-stack-kms-vault branch from f9b71cc to aeb384d Compare November 12, 2026 05:24
@freshtonic
freshtonic removed this pull request from stack #1623 November 12, 2026 05:28
@freshtonic

Copy link
Copy Markdown
Contributor Author

Replaced by #1628, in the new stack #1633. The code is the same, rebased onto the latest next. The ADRs are now ADR-0013 and ADR-0014, and the text about the wrapped data key mode is removed.

@freshtonic freshtonic closed this Nov 12, 2026
@freshtonic
freshtonic deleted the james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcp branch November 12, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant