Skip to content

feat(go): key vendor backends through the encrypt guest (CIP-5311) - #1630

Draft
freshtonic wants to merge 1 commit into
james/cip-5309-stack-kms-azurefrom
james/cip-5311-go-key-vendor-backends
Draft

freshtonic wants to merge 1 commit into
james/cip-5309-stack-kms-azurefrom
james/cip-5311-go-key-vendor-backends

Conversation

@freshtonic

Copy link
Copy Markdown
Contributor

Layer 8 of the CIP-5203 stack. Implements CIP-5311 (ADR-0014).

  • The encrypt guest links stack-kms-vendor and the four vendor crates. A vendor request is a step of the step loop: the guest pauses with the signed request, and the host performs it, as it does for ZeroKMS. A credential is a step too. The host supplies short-lived credentials only: AWS temporary credentials, or an OAuth or Vault token. There is no RSA in the guest; the GCP service-account login is behind a default feature.
  • Go API: WithKeyVendor, WithKeysetRecords, WithDefaultKeyset, WithRootKeyTTL, ErrNoZeroKMS. The vendor types are AWSKMS, GoogleCloudKMS, AzureKeyVault, VaultTransit and StaticKey. Credential seams are added; no vendor SDK is added to go.mod.
  • A vendor-only client needs no CipherStash credentials.
  • One guest with all backends.
  • Tests: hermetic Go tests with the static key, and with AWS through a fake RoundTripper that checks SigV4 and call counts.

Decisions are in docs/plans/2026-11-05-key-vendor-backends-decisions.md (CIP-5311 section).

@changeset-bot

changeset-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 747d42f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

@github-actions

Copy link
Copy Markdown
Contributor

Mutation testing (cargo-mutants, --in-diff, stack-auth + stack-encrypt)

cargo-mutants did not complete (exit ) before producing results. Check the workflow run logs. The gate below will fail.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant