Repository navigation
feat(stack-kms): typed errors and payload checks for key vendor backends (CIP-5304) - #1632
Draft
freshtonic wants to merge 1 commit into
Draft
freshtonic wants to merge 1 commit into
freshtonic wants to merge 1 commit into
Conversation
…nds (CIP-5304) Add Error::Backend and Error::ZeroKmsOnly, refuse_zerokms_extensions, IndexKey::from_key_bytes, the stable KeyVendor and KeyMode bytes, and the ZeroKmsKeySource marker. The key source traits are unchanged, so stack-encrypt does not change.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true |
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layer 2 of the CIP-5203 stack. Implements CIP-5304.
Error::Backend { vendor, kind, source }andError::ZeroKmsOnlyare added, withrefuse_zerokms_extensionsfor key vendor backends.KeyBackend,KeyVendorandKeyMode, with stable bytes that a keyset record stores.KeyModehas one variant,Derived, and is#[non_exhaustive].IndexKey::from_key_bytesis a public constructor.ZeroKmsKeySourcemarker, so a key router cannot hold a second router.stack-encryptdoes not change.Erroris not#[non_exhaustive], so the new variants are a breaking change to stack-kms.Decisions are in
docs/plans/2026-11-05-key-vendor-backends-decisions.md(CIP-5304 sections).