Repository navigation
feat(stack-kms-gcp): Google Cloud KMS key vendor backend (CIP-5308) - #1650
Draft
freshtonic wants to merge 1 commit into
Draft
freshtonic wants to merge 1 commit into
freshtonic wants to merge 1 commit into
Conversation
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: |
Contributor
Mutation testing (cargo-mutants,
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layer 6 of the CIP-5203 stack. Implements CIP-5308.
stack-kms-gcp: a Cloud KMS REST client (encrypt/decrypt) that supports both key modes. Data keys are generated locally, the AAD goes inadditionalAuthenticatedData, and CRC32C is checked on every field.rsacrate on wasm32), and the metadata server (native only).integration-gcp-kms.yml. To turn it on, set the variableSTACK_KMS_GCP_LIVE_KEYand the secretSTACK_KMS_GCP_SERVICE_ACCOUNT_KEY.rsa) no longer affects a native or Go guest build: native RS256 uses AWS-LC, and the guest builds withoutservice-account. Only a wasm32 build withservice-accountusesrsa; a security reviewer must sign that off before such a build is released. See the orchestrator review in the decision log.Replaces #1628, which was closed.