Conversation
The malachitebft Height trait documents decrement_by as returning None when the height would go below its minimum. Arc's impl wraps saturating_sub in Some, so it never returns None: decrementing below zero yields Some(Height(0)). This disagrees with the inherent decrement() (checked_sub) and increment_by (checked_add), and since the trait's default decrement() delegates to decrement_by, the trait and inherent decrement() diverge at the zero boundary. Use checked_sub. An existing test asserted the saturating result (Some(0) for an underflow); it now asserts None.
Ruzzgar
requested review from
ZhiyuCircle,
ancazamfir,
romac and
sergio-mena
as code owners
September 13, 2026 01:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Heighttrait documentsdecrement_byas returningNoneon underflow:Arc's impl wraps
saturating_subinSome, so it never returnsNone— forn > heightit yieldsSome(Height(0)). That contradicts the inherentdecrement()(checked_sub) andincrement_by(checked_add), and since the trait's defaultdecrement()delegates here, the trait and inherentdecrement()disagree at zero.Switched to
checked_sub. An existing test asserted the saturating result (Some(0)for an underflow); it now assertsNone.cargo test -p arc-consensus-typespasses.