Conversation
Signed-off-by: Hukla <129692708+huklaa@users.noreply.github.com>
huklaa
requested review from
ZhiyuCircle,
ancazamfir,
romac and
sergio-mena
as code owners
September 14, 2026 16:48
Contributor
|
Hi @huklaa, Thank you for your interest in contributing to Arc Node. This PR has been automatically closed because it does not reference a GitHub issue. All PRs must reference an existing issue using the format To contribute properly:
Please see our CONTRIBUTING.md for more details. |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The TypeScript declaration accepts "SkipCompare" as an argument to "addressEqual", but the runtime implementation passes the sentinel to "isAddressable()" before checking "isSkipCompare(other)".
This causes a valid, compiling assertion to fail because the sentinel object is rejected as an invalid address or account.
Changes
Testing
Scope
This is separate from #399 and #400, which concern the "hexEqual" matcher.
Closes: #407