-
Notifications
You must be signed in to change notification settings - Fork 473
docs(shared): document OAuth device verification types #9678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SarahSoutoul
wants to merge
9
commits into
main
Choose a base branch
from
ss/DOCS-12117
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0285805
docs(shared): document OAuth device verification types
SarahSoutoul cc21fd2
docs(shared): fix OAuth device verification TypeDoc output
SarahSoutoul 153bc28
docs(shared): inline OAuth device verification status
SarahSoutoul b5a735c
docs(shared): simplify device verification hook return
SarahSoutoul dc60f42
refactor(repo): simplify device verification TypeDoc
SarahSoutoul 53d4169
docs(repo): reserve device verification routes
SarahSoutoul 989d669
test(repo): remove redundant TypeDoc assertions
SarahSoutoul 6b28613
Merge branch 'main' into ss/DOCS-12117
SarahSoutoul 9e6f0c6
docs(shared): clarify useOAuthDeviceVerification error field semantics
manovotny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@clerk/shared': patch | ||
| --- | ||
|
|
||
| Document the public fields, actions, and parameter types for OAuth device verification flows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Do not promise request-order semantics that the hook does not enforce.
The implementation in
packages/shared/src/react/hooks/useOAuthDeviceVerification.tsxuses one sharederrorstate forlookupandsubmit, while allowing both operations to overlap. If a newerapprovesucceeds while an olderlookupis pending, the older lookup can reject afterward and populateerror. Therefore,erroris not always from the most recent request, and it is not necessarilynullafter the latest request succeeds. Either make error updates order-aware across both operations or document that this field contains the latest error recorded by either operation.This is based on the supplied hook implementation.
🤖 Prompt for AI Agents