Repository navigation
#65 - Deprecate the configuration keys, ignored without notice (no Configuration) - #66
Merged
Merged
Conversation
…nfiguration) The bundle has no configuration: the keys under clever_age_cache_process were ignored without notice. New internal Configuration with an empty tree (keys still ignored), deprecation when a key is configured, rejection in 3.0. Tests, documentation and CHANGELOG updated. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #65.
DependencyInjection\Configurationwith an empty tree (ignoreExtraKeys()):config:dump-reference clever_age_cache_processworks, the configured keys are still ignored.load(): configuring a key triggers a deprecation when the container is compiled:Since cleverage/cache-process-bundle 2.3: Configuring "clever_age_cache_process" is deprecated, the bundle has no configuration: the keys "foo" are ignored. They will be rejected in 3.0.ignoreExtraKeys()and the deprecation, the unknown keys are rejected.composer.json: requiresymfony/deprecation-contracts(trigger_deprecation()used directly).docs/index.md, Configuration). CHANGELOG.Tests (extension test): deprecation with keys (merged from several configuration files), no deprecation without key, the
Configurationis the one of the extension.Checked in the container (PHP 8.5, highest dependencies): 77 tests, 100 % of the lines, no risky test (pcov coverage). PHPStan, PHP-CS-Fixer and Rector OK.
Requirements
Breaking changes
None in 2.3: new deprecation, the keys are still ignored. Rejection of the keys in 3.0.
🤖 Generated with Claude Code