Repository navigation
#75 - FileFetchTask: explicit failure for an unknown storage - #76
Merged
Merged
Conversation
…for an unknown storage, and with an explicit message when the task is executed after a failed initialization instead of an uninitialized property error or the storages of a previous initialization. Update documentation, add tests. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #75.
FileFetchTask::initialize()resolves the storages through a newgetStorage(): an unknown storage throwsUnexpectedValueException('Unknown storage "…" (option "…"), known storages: "…"')instead ofService "…" not found.execute()fails with an explicit message when the storages are not available (process-bundle v5 executes the task after a failed initialization), instead ofTyped property FileFetchTask::$sourceFS must not be accessed before initialization.file_fetch_task.md: the note no longer says that the process fails before any task is executed.Requirements
Breaking changes
None: only the messages of failures change.
🤖 Generated with Claude Code