Repository navigation
#335 - LineReaderTask: do not lose the last line of a file without final line break - #336
Open
njoubert-cleverage wants to merge 2 commits into
Open
njoubert-cleverage wants to merge 2 commits into
njoubert-cleverage wants to merge 2 commits into
Conversation
…to read instead of at the end of the file, so that the last line of a file that does not end with a line break is no longer lost. Add tests. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #335.
LineReaderTask::next()(also used byInputLineReaderTask) stops the iteration whenSplFileObject::valid()is false instead of wheneof()is true: withREAD_AHEAD, the end of the file is reached as soon as the last line is read, so the last line of a file without final line break was never emitted.l1\n\nl3\r\nl4, for both tasks.Requirements
Breaking changes
None: files ending with a line break are read as before.
🤖 Generated with Claude Code