Repository navigation
#337 - StopTask: make the process fail for real - #338
Open
njoubert-cleverage wants to merge 1 commit into
Open
njoubert-cleverage wants to merge 1 commit into
njoubert-cleverage wants to merge 1 commit into
Conversation
…ask stops its state with a ProcessStoppedException, so that the process manager throws a ProcessFailedException (fail event, non-zero exit code, failure of the parent process_executor task). Update documentation and tests. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #337.
StopTaskstops its state with a newProcessStoppedException::createByTask()("Process X has been stopped by task Y."): the process manager throws aProcessFailedException, as for thestoperror strategy and the stop checkers. The process really fails:cleverage_process.failevent, no finalization, non-zero exit code ofcleverage:process:execute, failure of theprocess_executortask of a parent process (handled by itserror_strategy).stop_task.md(how the process fails, alternatives to end a flow without failure),04-advanced_workflow.md,01-process_definition.md(failed_level),02-task_types.md(finalization).StopTaskTest,ProcessManagerEndLogTest.Requirements
Breaking changes
Behaviour change: a process using the
stoptask now fails (exception, non-zero exit code, no finalization) instead of ending normally with a history flagged as failed. This is what the task documented; processes usingstopto end a flow without failure must filter their items instead. To be mentioned in theUPGRADE.mdsection of the release.🤖 Generated with Claude Code