Repository navigation
#343 - Create the temporary files with a random name, exclusively and for their owner only - #344
Open
njoubert-cleverage wants to merge 2 commits into
Open
njoubert-cleverage wants to merge 2 commits into
njoubert-cleverage wants to merge 2 commits into
Conversation
…k and of the JSON buffer of ProcessLauncherTask with a random name, exclusively and readable by their owner only (new internal TemporaryFile). Update documentation, add tests. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #343.
Filesystem\TemporaryFile::create(): file in the system temporary directory, random name (random_bytes()), exclusive creation (fopen()modex: fails on an existing path, symbolic links included), permissions0600.FileSplitterTask(.tmp),CsvSplitterTask(.csv) andSubprocessInstance(JSON buffer ofProcessLauncherTask, created when the sub-process is built withjson_buffering, before it writes into it).file_splitterandcsv_splitter.TemporaryFileTest,SubprocessInstanceTest(buffer created with0600).The temporary files are still not deleted by the bundle: they are the output of the tasks, read by the next ones.
Requirements
Breaking changes
None: only the name and the permissions of the temporary files change.
🤖 Generated with Claude Code