Repository navigation
#367 - process_launcher with json_buffering: output nothing for an empty buffer, remove the buffers of failed sub-processes - #374
Merged
Conversation
…e the buffer when the sub-process wrote nothing into it, remove the buffers of failed and stopped sub-processes Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #367.
Regression of 5.5 (#343): the JSON buffer of
process_launcher(json_buffering) is created before the sub-process is launched, soSubprocessInstance::getResult()returned the path of an emptycdm_buffer_*.json-streamfile when the sub-process wrote nothing (noend_point, or an output that is not an array), and the buffers were never removed.SubprocessInstance::getResult()removes an empty buffer and returnsnull: the task outputs nothing again, as in 5.4.1 and as documented.SubprocessInstance::removeBuffer(), called byProcessLauncherTaskfor a failed sub-process and for the still running sub-processes stopped because of it (their buffers are never output). An already terminated sub-process keeps its buffer and is handled normally (output on the next call witherror_strategy: skip).Requirements
Breaking changes
None: the path of a non-empty buffer is still output and kept; only empty buffers (which were not output before 5.5) and the buffers of failed / stopped sub-processes are removed.
🤖 Generated with Claude Code