Repository navigation
Backport to 5.5 the fixes merged into main after 5.5 (#367, #368, #369, #370, #372, #373) - #383
Closed
njoubert-cleverage wants to merge 7 commits into
Closed
njoubert-cleverage wants to merge 7 commits into
njoubert-cleverage wants to merge 7 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> # Conflicts: # CHANGELOG.md
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…e the buffer when the sub-process wrote nothing into it, remove the buffers of failed and stopped sub-processes Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ave the invalid processes out of the listings Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…UPGRADE section v5.5.1 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Not needed: there is no 5.5 branch, the next release (5.5.1) is made from main, which already contains these fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport, for a 5.5.1 release, of the fixes merged into
mainafter the 5.5 release. The5.5branch was created from thev5.5tag. The deprecation of #371 stays inmain(5.6).main: rules: a condition that does not evaluate to a boolean throws a TypeError #370 (#370 - rules: cast the result of a condition to bool #377), StopTask flags a failed process as stopped #369 (#369 - StopTask: keep a failed process failed #376), yaml_writer: the parent directory is created without condition, a stream wrapper path fails #368 (#368 - yaml_writer: create the parent directory for a local path only #375), process_launcher with json_buffering outputs the path of an empty buffer and leaves the buffers in the temporary directory #367 (#367 - process_launcher with json_buffering: output nothing for an empty buffer, remove the buffers of failed sub-processes #374), An unknown task reference in one process makes every process listing fail, with a message naming neither the process nor the task #372 (#372 - Name the process and the task of an unknown task reference, leave the invalid processes out of the listings #378), The tasks are not finalized when the process fails: resources left open in a long-running worker #373 (#373 - Finalize the initialized tasks when the process fails #379). OnlyCHANGELOG.mdconflicted.Latestsection of the CHANGELOG lists the 6 fixes, and theUPGRADE.mdsection of The tasks are not finalized when the process fails: resources left open in a long-running worker #373 (finalization of the tasks when the process fails) isv5.5.1instead ofv5.6.When 5.5.1 is released,
5.5will be merged intomain(CHANGELOG:v5.5.1section,Latestkeeping #371; UPGRADE:v5.5.1section).Requirements
Breaking changes
None beyond those of the backported PRs. #373 changes the contract of
FinalizableTaskInterface::finalize()(also called when the process fails), described inUPGRADE.md.🤖 Generated with Claude Code