Skip to content

#66 - RequestTask: meaningful log message for a failed call, minor cleanups, document the shared client state - #67

Merged
njoubert-cleverage merged 1 commit into
mainfrom
66
Oct 21, 2026
Merged

njoubert-cleverage merged 1 commit into
mainfrom
66

Conversation

@njoubert-cleverage

Copy link
Copy Markdown
Member

Description

Fixes #66.

  • RequestTask logs a failed call (SoapFault) as Soap call failed instead of the misleading Empty resultset for query: same error level and log context (options, fault message, last request and response).
  • RequestTransformer: remove the monolog.logger tag, the transformer has no logger (the tag had no effect).
  • MissingClientException::create(string $code) is typed (the @param string PHPDoc is removed); ClientRegistry passes a string.
  • Client reference: a client, shared, keeps its state between two process executions in a long-running worker (Messenger, ui-process-bundle): SoapClient and WSDL, options and headers changed with the setters, last traces. Completes the existing note on shared clients. No ResetInterface: the bundle never changes the WSDL, restores the options and headers after each call, the traces are overwritten at each call, keeping the SoapClient is wanted, and a reset to the constructor values would undo the calls of the service definitions.
  • request_task.md and the soap_enrich_csv cookbook mention the new log message. CHANGELOG.

Tests: RequestTaskTest::testFailedCall checks the new message; the extension test checks that the transformer has no monolog.logger tag.

Checked in the container (highest dependencies after composer update): 52 tests (1 skipped, as on main: KernelTest needs process-bundle 5.4), 100 % of the lines (226/226), no risky test (pcov coverage). PHPStan, PHP-CS-Fixer and Rector OK.

Requirements

  • Documentation updates
    • Reference
    • Changelog
  • Unit tests

Breaking changes

None. The log message of a failed call changes (an alert or a log filter on Empty resultset for query must be updated). Calling MissingClientException::create() with a non-string code from a file in strict_types mode throws a TypeError (the codes are strings everywhere in the bundle).

🤖 Generated with Claude Code

…eanups, document the shared client state

RequestTask logs a failed call as "Soap call failed" instead of the
misleading "Empty resultset for query". Remove the monolog.logger tag of
RequestTransformer, which has no logger. Type
MissingClientException::create(string $code). Document that a shared
client keeps its state between two executions in a long-running worker.
Tests, documentation and CHANGELOG updated.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@njoubert-cleverage
njoubert-cleverage merged commit 4eb06b6 into main Oct 21, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RequestTask: meaningful log message for a failed call, minor cleanups, document the shared client state

1 participant