Repository navigation
#66 - RequestTask: meaningful log message for a failed call, minor cleanups, document the shared client state - #67
Merged
Merged
Conversation
…eanups, document the shared client state RequestTask logs a failed call as "Soap call failed" instead of the misleading "Empty resultset for query". Remove the monolog.logger tag of RequestTransformer, which has no logger. Type MissingClientException::create(string $code). Document that a shared client keeps its state between two executions in a long-running worker. Tests, documentation and CHANGELOG updated. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #66.
RequestTasklogs a failed call (SoapFault) asSoap call failedinstead of the misleadingEmpty resultset for query: sameerrorlevel and log context (options, fault message, last request and response).RequestTransformer: remove themonolog.loggertag, the transformer has no logger (the tag had no effect).MissingClientException::create(string $code)is typed (the@param stringPHPDoc is removed);ClientRegistrypasses a string.SoapClientand WSDL, options and headers changed with the setters, last traces. Completes the existing note on shared clients. NoResetInterface: the bundle never changes the WSDL, restores the options and headers after each call, the traces are overwritten at each call, keeping theSoapClientis wanted, and a reset to the constructor values would undo thecallsof the service definitions.request_task.mdand thesoap_enrich_csvcookbook mention the new log message. CHANGELOG.Tests:
RequestTaskTest::testFailedCallchecks the new message; the extension test checks that the transformer has nomonolog.loggertag.Checked in the container (highest dependencies after
composer update): 52 tests (1 skipped, as onmain:KernelTestneeds process-bundle 5.4), 100 % of the lines (226/226), no risky test (pcov coverage). PHPStan, PHP-CS-Fixer and Rector OK.Requirements
Breaking changes
None. The log message of a failed call changes (an alert or a log filter on
Empty resultset for querymust be updated). CallingMissingClientException::create()with a non-string code from a file instrict_typesmode throws aTypeError(the codes are strings everywhere in the bundle).🤖 Generated with Claude Code