#73 - RequestTransformer: private again

CHANGELOG.md

@@ -1,6 +1,9 @@
 Latest
 ------
 
+### Fixes
+* [#73](https://github.com/cleverage/soap-process-bundle/issues/73) `RequestTransformer` is a private service again, as in 3.2: 3.3 made it public by mistake, with the deprecation of a direct access from the service container that never existed. `UPGRADE.md` (3.3) only mentions the task. Update tests.
+
 v3.3.1
 ------
 

UPGRADE.md

@@ -35,8 +35,8 @@ tasks:
 | `cleverage_soap_process.task.request`        | `RequestTask`        | `soap_request` |
 | `cleverage_soap_process.transformer.request` | `RequestTransformer` | `soap_request` |
 
-The service id of the task and the transformer is their class name. Fetching them from the service container
-(`$container->get()`) is deprecated: they will be private in 4.0.
+The service id of the task and the transformer is their class name. Fetching the task from the service container
+(`$container->get()`) is deprecated: it will be private in 4.0 (the transformer is private, as before).
 
 ### Client codes
 

config/services/transformer.yaml

@@ -1,9 +1,7 @@
 services:
     _defaults:
-        # Public for the direct access from the service container, deprecated since 3.3: private in 4.0
-        public: true
-        tags:
-            - { name: container.private, package: cleverage/soap-process-bundle, version: '3.3' }
+        # Private, as in 3.2: the transformers are fetched by their code
+        public: false
 
     CleverAge\SoapProcessBundle\Transformer\RequestTransformer:
         arguments:

tests/DependencyInjection/CleverAgeSoapProcessExtensionTest.php

@@ -139,9 +139,9 @@ public function testTransformerIsRegistered(): void
         $code = (new RequestTransformer(new ClientRegistry()))->getCode();
         self::assertSame('soap_request', $code);
         self::assertSame([['code' => $code]], $transformer->getTag('cleverage.transformer'));
-        // Public for the direct access from the service container, deprecated
-        self::assertTrue($transformer->isPublic());
-        self::assertSame([['package' => 'cleverage/soap-process-bundle', 'version' => '3.3']], $transformer->getTag('container.private'));
+        // Private, as in 3.2: it was never fetched directly from the service container
+        self::assertFalse($transformer->isPublic());
+        self::assertFalse($transformer->hasTag('container.private'));
         // No logger
         self::assertFalse($transformer->hasTag('monolog.logger'));
         $arguments = $transformer->getArguments();