Repository navigation
#196 - Prefix the upload_directory parameter and the Twig functions and filter, deprecate the former names - #197
Merged
Merged
Conversation
…nd filter, deprecate the former names New cleverage_ui_process.upload_directory parameter; upload_directory is deprecated, still honoured when the application sets it (new internal UploadDirectoryParameterPass). The Twig functions and the md5 filter are prefixed with cleverage_ui_process_, the former names are deprecated Twig callables. Removed in 4.0. Tests, documentation, UPGRADE.md and CHANGELOG. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #196, as the route names (#172): the global names of the bundle are prefixed, the former ones deprecated and removed in 4.0.
cleverage_ui_process.upload_directoryparameter, used by the launch form and the HTTP API.upload_directorykeeps the same value (%cleverage_ui_process.upload_directory%) and is deprecated: reading it triggers a deprecation (ContainerBuilder::deprecateParameter()), and when the application still sets it, its value is used with a deprecation, unless the new parameter is also set (new internalUploadDirectoryParameterPass, at compile time).log_label,log_translation,log_css_class,get_last_execution_date,get_process_source,get_process_target,resolve_ui_optionsand the filtermd5get acleverage_ui_process_prefixed name, used by the templates of the bundle. The former names stay, deprecated withDeprecatedCallableInfo(notice when a template using them is compiled, e.g. "Twig Function "log_label" is deprecated; use "cleverage_ui_process_log_label" instead").Out of scope (BC, 4.0): translation domains,
ui:BootstrapModalcomponent,cronschedule,execute_processtransport,process_user_provider.Tests:
UploadDirectoryParameterPassTest(defaults, new parameter, deprecated parameter set, both set, deprecation when reading), registration of the pass, the Twig extension tests check the prefixed names and the deprecations of the former ones. The test application uses the new parameter.Checked:
lint:containerOK,lint:twig --show-deprecationson the templates of the bundle without deprecation, process list, executions and logs lists (log level badges), launch form with a file upload saved invar/storage/uploads.Requirements
Breaking changes
None: the former names keep working, deprecated.
🤖 Generated with Claude Code