Repository navigation
#186 - Type the process manager and the process configuration registry on their process-bundle interfaces - #204
Merged
Merged
Conversation
…y on their process-bundle interfaces Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #186.
The five constructors typed on the concrete classes of process-bundle (
@final since 5.4,finalin v6.0) are typed on the interfaces added by cleverage/process-bundle#312 (5.4), so that an application can decorate or replace these services for the UI:Controller\ProcessExecuteControllerProcessManagerProcessManagerInterfaceMessage\ProcessExecuteHandlerProcessManagerProcessManagerInterfaceForm\Type\LaunchTypeProcessConfigurationRegistryProcessConfigurationRegistryInterfaceManager\ProcessConfigurationsManagerProcessConfigurationRegistryProcessConfigurationRegistryInterfaceValidator\IsValidProcessCodeValidatorProcessConfigurationRegistryProcessConfigurationRegistryInterfaceThey only use methods of the interfaces (
execute(),getProcessConfiguration(),getProcessConfigurations(),hasProcessConfiguration()). The services are still wired explicitly with@cleverage_process.manager.process/@cleverage_process.registry.process_configuration, unchanged. The tests stub / mock the interfaces instead of the concrete classes.cleverage/process-bundle: ^5.4is already required since 3.3: no change incomposer.json.Checked locally with coverage (pcov): 482 tests, no risky test; PHPStan, PHP-CS-Fixer, Rector and Twig-CS-Fixer OK.
Requirements
Breaking changes
None: the constructor parameters are widened (the concrete classes implement the interfaces).
🤖 Generated with Claude Code