Repository navigation
#220 - Record a process stopped by a StopTask with the stopped status - #221
Merged
Merged
Conversation
…pped status (ProcessEvent::isProcessStopped(), when provided by the process bundle) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #220.
A process stopped on purpose by a
StopTask(e.g. not going on when the source file does not exist) is recorded with thestoppedstatus, and notified asstopped, instead offinish.ProcessEventSubscriber::success():stoppedstatus whenProcessEvent::isProcessStopped()is true. This method is added by StopTask: identify a process stopped on purpose as stopped, not as failed process-bundle#337 (PR #337 - StopTask: a process stopped on purpose ends as stopped, not as failed process-bundle#338): it is called only when it exists, an older process bundle keeps thefinishstatus. Once the process bundle version providing it is required, themethod_exists()check, the skip of the test and thephpstan.neonignored errors can be removed.stoppedstatus on process end), notifications (stoppedtrigger).ProcessEventSubscriberTest::testProcessStoppedByAStopTask()(skipped with the released process bundle).Tested with the released process bundle (v5.4.1) and with the branch of cleverage/process-bundle#338: PHPUnit, PHPStan, PHP-CS-Fixer, Rector.
Requirements
Breaking changes
None: with the process bundle providing
ProcessEvent::isProcessStopped(), a process stopped by aStopTaskgets thestoppedstatus instead offinish(not notified by default).🤖 Generated with Claude Code