Repository navigation
#222 - Login throttling: an application with another firewall than main can boot again - #223
Merged
Merged
Conversation
…with the rest of the main firewall, so that an application declaring another firewall (dev) can still boot Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #222.
The login throttling of the
mainfirewall (#207, PR #208, not released) was prepended: as the first definition of thefirewallsnode, it prevented the application from declaring any other firewall (e.g. thedevfirewall of the Symfony recipe), the kernel did not boot ("You are not allowed to define new elements for path "security.firewalls"").CleverAgeUiProcessExtension:login_throttling: []is added with the rest of themainfirewall, after the application configuration. Merged after it, it keeps the settings of the application.devfirewall declared beforemain, as in the Symfony recipe (the functional tests failed with this error without the fix).03-users_and_security.md.Checked:
login_throttling: { max_attempts: 3 }in themainfirewall of the test application:debug:config security firewalls.main.login_throttlinggivesmax_attempts: 3;devandmainfirewalls) boots again (it still needssymfony/rate-limiter, required since Login form without throttling #207).Requirements
Breaking changes
None.
🤖 Generated with Claude Code