Repository navigation
#228 - Uploaded files: only delete the files written for the execution, keep them while a failed message will be retried - #231
Merged
Conversation
… them while a failed message will be retried, delete them on a rejected HTTP request Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
njoubert-cleverage
force-pushed
the
228
branch
from
October 23, 2026 19:33
290cf3b to
7dd1d81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #228.
Regression of 3.4 (#209): any input located directly in the upload directory was deleted after the execution, even when given by its path (an API user could delete a file of another user waiting in the queue; schedules and default inputs lost their reference file), the file was also deleted when the execution failed (a retried message ran without its file), and the file written for a request rejected by the HTTP API (422) was never deleted.
ProcessExecuteMessagegets an optionaldeleteInputargument (falseby default, positional compatibility kept; a message serialized by 3.4 is read asfalse). OnlyLaunchActionand the HTTP API set it, for the file they have just written (the HTTP value resolver flags it with a request attribute, not in the deserialized model, so that a client cannot set it). The upload directory check ofUploadedFileManageris kept as defense in depth;cleverage_ui_process.delete_uploaded_files: falsestill disables the deletion.messenger:failed:retry), asSendFailedMessageToFailureTransportListenerdecides depending on the Symfony version: new internalUploadedFileSubscriber(worker events) andUploadedFileSubscriberPass(failure transports). Outside of a worker (sync transport, unrouted message), the handler deletes the file after a successful or failed execution.Requirements
Breaking changes
None: a file given by its path is no longer deleted (regression of 3.4); the changed signatures (
LaunchAction::dispatch(),ProcessExecuteHandler,ProcessExecuteController) are internal.🤖 Generated with Claude Code