fix(typescript): sequence async websocket decompression to prevent ou… - #5845
Open
rohanranjan0902 wants to merge 1 commit into
Open
fix(typescript): sequence async websocket decompression to prevent ou…#5845rohanranjan0902 wants to merge 1 commit into
rohanranjan0902 wants to merge 1 commit into
Conversation
…t-of-order frame delivery (fixes clockworklabs#5730)
|
Rohan Ranjan Prasad seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR fixes a bug in the TypeScript SDK where compressed WebSocket frames could be delivered out of order to the
DbConnection.Previously,
WebsocketDecompressAdapterbound anasynchandler directly tows.onmessage. Because decompression time scales with payload size, a small frame could finish decompressing before a larger frame that arrived earlier, resulting in out-of-order delivery and silent client cache corruption.To fix this, this PR decouples the concurrent decompression step from the delivery callback by sequencing the deliveries through a Promise chain (
tail). The decompression itself still occurs concurrently, but the hand-off to the SDK is strictly ordered by the socket arrival sequence.Fixes #5730
API and ABI breaking changes
None. This is an internal fix to the WebSocket adapter.
Expected complexity level and risk
2
The change modifies the asynchronous delivery logic of the WebSocket adapter. While the logic is well-contained, Promise chaining can be a bit subtle. We made sure to properly handle rejections so that decompression errors (e.g. "Incomplete compressed input") don't surface as unhandled rejections and will still correctly close the socket.
Testing
pnpm run buildlocally.