Repository navigation
fix(vibe): Remove person names from the plugin - #286
Merged
Merged
Conversation
- Operator ruling, 2026-10-14: plugin text never names people. Rulings are cited as "operator ruling, <date>"; the person running a session, engineering, the operator and design stand in for names in skills, agents, references, scripts, tests, comments, the README and the vibe CHANGELOG entries. - The vibe skill description keeps its trigger as "for a non-engineer (such as a CEO)". The cl-execute gate is the Design Visual-QA Gate (#design-visual-qa-gate), the heavy handoff checks list product-contract QA for /metal-andrew, and the cl-sweep summary heading is `Needs you:`. - vibe-setup-worker and cl-work-report route by the ClosedLoop user ids the names resolved to, so assignment and owner protection behave the same. The /metal-andrew command and the legacy repo-memory keys cl-policy reads stay spelled as their owners spell them. - New test_vibe_no_person_names_contract.py fails when a known name appears anywhere under plugins/vibe/; the names are stored as digests. - Bump vibe to 1.0.34. Testing: the new contract test fails on 1.0.33 with 331 hits and passes here. Contract tests now assert the new wording. vibe pytest (177), vibe node suites (283), ruff, pyright and the plugin manifest tests pass; the vibe-workers bundle rebuilds unchanged. Risks: text shown to the person on a blocked session now says to message engineering rather than a named engineer.
- 1.0.34 is claimed by the open compile-only repair PR, so this branch takes the next free version. Testing: plugin manifest versions match. Risks: None identified
# Conflicts: # CHANGELOG.md # plugins/vibe/.claude-plugin/plugin.json # plugins/vibe/.codex-plugin/plugin.json # plugins/vibe/skills/handoff/scripts/handoff-inventory.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Operator ruling, 2026-10-14: plugin code and prose never name people. This removes every person's name from
plugins/vibe/and from the### vibe v*CHANGELOG entries, with no behavior change. Bumps vibe to 1.0.35 (1.0.34 is #285, merged into this branch; its new text is name-free).What changed
cl-*skills.vibeskill description keeps its trigger: "for a non-engineer (such as a CEO) working in the Codex Desktop in-app browser".cl-execute's gate is the "Design Visual-QA Gate" (anchor#design-visual-qa-gate, all links updated); the heavy handoff checks list "product-contract QA" for/metal-andrew; the cl-sweep summary heading isNeeds you:.vibe-setup-workerassigns its bug ticket andcl-work-reportprotects its two owners by the ClosedLoop user ids the names resolved to, so routing is unchanged./metal-andrew/$metal-andrewcommand (a symphony-alpha skill id) and the legacy repo-memory keyscl-policyreads from older records (daniel_dm*,Daniel-attention); live records still carry them.plugins/vibe/tools/python/test_vibe_no_person_names_contract.pyfails when a known name appears anywhere underplugins/vibe/(names stored as digests, the two identifiers above allow-listed, the vendored mermaid bundle skipped).Commands run
uv run pytest -q plugins/vibe: 183 passednode --testover every vibe*.test.mjs: 284 passeduv run ruff check .,uv run pyright: cleantools/plugin-manifests:npm test6 passedtools/vibe-workers:npm run typecheck,npm run build(committeddist/unchanged)