Repository navigation
fix(core): trigger prevention on non-code corrections - #288
Merged
Merged
Conversation
- Activate prevention for reusable lessons from setup, measurement, validation, workflow, and code corrections - Preserve explicit exclusions and pin the trigger contract - Bump closedloop-core to 1.4.1 and refresh generated docs Testing: uv run pytest plugins/closedloop-core/tools/python/ -q; uv run ruff check .; uv run pyright; skill quick_validate; plugin-manifests test and typecheck Risks: None identified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installed
closedloop-corev1.4.0 advertisedprevent-recurrencefor bugs and accepted code-review findings, so an agent correcting a setup, measurement, validation, or workflow failure could miss the skill even when the correction exposed a reusable prevention lesson.This broadens the skill's frontmatter and opening guidance to cover any corrected issue or failure with a reusable prevention lesson, including code and non-code mistakes. It preserves the exclusions for ordinary feature work, rejected findings, and external outages or flaky infrastructure with no agent or system mistake. The dedicated contract test now pins both the broader trigger and those exclusions, and the plugin is bumped to v1.4.1.
Validation:
uv run pytest plugins/closedloop-core/tools/python/ -q(43 passed)uv run ruff check .uv run pyrightuv run --with pyyaml python /Users/daniel.ochoa/.codex/skills/.system/skill-creator/scripts/quick_validate.py plugins/closedloop-core/skills/prevent-recurrencenpm testandnpm run typecheckintools/plugin-manifests(6 tests passed)git diff --checkPrevention
plugins/closedloop-core/skills/prevent-recurrence/SKILL.mdand its README summary; no other canonical or adapter copy required a source change.rg -n --hidden --glob '!**/.git/**' 'prevent-recurrence|accepted code-review finding|A fixed instance is not a fixed mistake' .plugins/closedloop-core/tools/python/test_prevent_recurrence_skill_contract.py.correcting an issue or failure, then passed after the skill update.