Repository navigation
fix(vibe): Ask resume or new before searching sessions - #290
Merged
Merged
Conversation
Starting $vibe used to run the previous-session search first, and watching a real run showed it takes too long (operator ruling, 2026-10-15). The orchestrator now settles resume or new from the person's own words, asks one plain question only when that is unclear, skips the search for a new session, and runs the session list only after the person chose to resume.
…fore-search # Conflicts: # plugins/vibe/.claude-plugin/plugin.json # plugins/vibe/.codex-plugin/plugin.json
The README said handoff blocks any other edit of a v1.0 file, which no longer holds: compile-only repairs are allowed and Start Here stories are exempt. It now says what guardrails.md says, and the two contract tests pin the new sentence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting
$vibeno longer runs the previous-session search before anything else (operator ruling, 2026-10-15). Watching a real run, that search took too long.skills/vibe/SKILL.md, section 2: the orchestrator first settles resume or new. "pick up where I left off", "resume", or a named session or slug means resume; a ticket or a description of new work means new. Only when that is unclear does it ask one plain question: "Do you want to pick up something you worked on before, or start something new?"vibe-sessions.mjs listnow runs only under "Finding a session to resume", after the person chose resume, and what it finds is offered then (a named session is offered first). The stale-session prompt and the handed-off rule moved with it. The old "match a new request against every session" step is gone.newrefuses a taken slug, the orchestrator derives another slug instead of searching.listkeeps its shape for handoff's step 0.Preflight, connector checks and repo choice are unchanged. One consequence: someone who starts new is no longer reminded about older sessions that were never handed off; they see that reminder when they choose resume.
Measured locally (read-only):
node vibe-sessions.mjs listtook 2.2 to 3.2 s for 3 sessions on a 51-worktree checkout, withgit status --porcelainat 0.3 to 0.6 s per session worktree, so it grows with each open session. The orchestrator turns spent matching the result came on top of that.Also fixes a stale README line: it said handoff blocks any other edit of a v1.0 file. It now says what
guardrails.mdsays (compile-only repairs allowed,Start Here/stories exempt), andtest_vibe_storybook_existing_component_contract.pyandtest_vibe_v1_compile_only_repair_contract.pypin the new sentence.Merged main after #289 (vibe 1.0.37). Bumps vibe to 1.0.38 with a CHANGELOG entry.
Tests: new
test_vibe_start_ask_before_search_contract.py(6 cases). 5 fail on main and pass here; the sixth pins handoff's unchanged use oflist.uv run pytest plugins/vibe/tools/python: 187 passed after the merge.ruff checkclean.