Repository navigation
fix(vibe): Set IN_PROGRESS after cl-execute gate - #294
Merged
Merged
Conversation
- cl-execute intake step 7 no longer marks tickets IN_PROGRESS before the readiness gate; a gate that ends in BLOCKED_BEFORE_START, including HUMAN_REVIEW_REQUIRED, leaves the status unchanged, which matches result-formats.md - Step 10 now sets IN_PROGRESS only after the gate returns GO, or GO_WITH_UI_PLAN_APPROVAL and planning proceeds - cl-sweep states the same rule for its ticket workers - Bump vibe to 1.0.42 in both manifests and add the changelog entry Testing: node --test on cl-sweep and cl-execute scripts (182 pass), uv run pytest plugins/vibe (211 pass), tools/plugin-manifests npm test (6 pass) Risks: None identified; prose-only change to skill instructions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
cl-executegave contradictory status instructions to a run that blocks at the readiness gate. Intake step 7 said to mark the ticketIN_PROGRESSwhen evaluation starts, butreferences/result-formats.mdsays a gate that blocks returnsBLOCKED_BEFORE_STARTwithFeature status: <unchanged status>. This came up on a real run against ISS-12552.Now the status moves only once the gate lets work proceed:
IN_PROGRESSduring intake or the readiness gate. A gate that ends inBLOCKED_BEFORE_START, includingHUMAN_REVIEW_REQUIRED, leaves every feature status unchanged.GO, orGO_WITH_UI_PLAN_APPROVALand planning proceeds, mark each included non-terminal, non-currently-blocked featureIN_PROGRESS, then confirm it before returning a planning wait or starting execution.cl-sweepsaid the same thing as the old step 7 ("a ticket worker that begins evaluation, requirements discovery, or plan creation must mark the featureIN_PROGRESS"). It now states the gate-first rule too.result-formats.mdalready matched the intended behavior and is unchanged.Files changed
plugins/vibe/skills/cl-execute/SKILL.md(intake steps 7 and 10)plugins/vibe/skills/cl-sweep/SKILL.md(ticket worker status rule)plugins/vibe/.claude-plugin/plugin.json,plugins/vibe/.codex-plugin/plugin.json(1.0.41 to 1.0.42)CHANGELOG.md(### vibe v1.0.42)Commands run
No test pinned the old wording, so no test changed. No Python was touched.