Skip to content

fix(vibe): Set IN_PROGRESS after cl-execute gate - #294

Merged
shafty023 merged 1 commit into
mainfrom
fix/cl-execute-in-progress-after-gate
Oct 15, 2026
Merged

shafty023 merged 1 commit into
mainfrom
fix/cl-execute-in-progress-after-gate

Conversation

@shafty023

Copy link
Copy Markdown
Collaborator

Purpose

cl-execute gave contradictory status instructions to a run that blocks at the readiness gate. Intake step 7 said to mark the ticket IN_PROGRESS when evaluation starts, but references/result-formats.md says a gate that blocks returns BLOCKED_BEFORE_START with Feature status: <unchanged status>. This came up on a real run against ISS-12552.

Now the status moves only once the gate lets work proceed:

  • Step 7: do not mark any included feature IN_PROGRESS during intake or the readiness gate. A gate that ends in BLOCKED_BEFORE_START, including HUMAN_REVIEW_REQUIRED, leaves every feature status unchanged.
  • Step 10: only after the gate returns GO, or GO_WITH_UI_PLAN_APPROVAL and planning proceeds, mark each included non-terminal, non-currently-blocked feature IN_PROGRESS, then confirm it before returning a planning wait or starting execution.
  • cl-sweep said the same thing as the old step 7 ("a ticket worker that begins evaluation, requirements discovery, or plan creation must mark the feature IN_PROGRESS"). It now states the gate-first rule too.

result-formats.md already matched the intended behavior and is unchanged.

Files changed

  • plugins/vibe/skills/cl-execute/SKILL.md (intake steps 7 and 10)
  • plugins/vibe/skills/cl-sweep/SKILL.md (ticket worker status rule)
  • plugins/vibe/.claude-plugin/plugin.json, plugins/vibe/.codex-plugin/plugin.json (1.0.41 to 1.0.42)
  • CHANGELOG.md (### vibe v1.0.42)

Commands run

node --test plugins/vibe/skills/cl-sweep/scripts/*.test.mjs plugins/vibe/skills/cl-execute/scripts/*.test.mjs   # 182 pass, 0 fail
uv run pytest plugins/vibe -q                                                                                    # 211 passed
cd tools/plugin-manifests && npm ci && npm test                                                                  # 6 passed

No test pinned the old wording, so no test changed. No Python was touched.

- cl-execute intake step 7 no longer marks tickets IN_PROGRESS before
  the readiness gate; a gate that ends in BLOCKED_BEFORE_START,
  including HUMAN_REVIEW_REQUIRED, leaves the status unchanged, which
  matches result-formats.md
- Step 10 now sets IN_PROGRESS only after the gate returns GO, or
  GO_WITH_UI_PLAN_APPROVAL and planning proceeds
- cl-sweep states the same rule for its ticket workers
- Bump vibe to 1.0.42 in both manifests and add the changelog entry

Testing: node --test on cl-sweep and cl-execute scripts (182 pass),
uv run pytest plugins/vibe (211 pass), tools/plugin-manifests npm test
(6 pass)

Risks: None identified; prose-only change to skill instructions
@shafty023
shafty023 merged commit adabe4a into main Oct 15, 2026
10 checks passed
@shafty023
shafty023 deleted the fix/cl-execute-in-progress-after-gate branch October 15, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant