Repository navigation
fix(deps): update workers-sdk derived dependencies - #637
ant-release-bot wants to merge 1 commit into
Conversation
commit: |
There was a problem hiding this comment.
@cloudflare/deploy-helpers 0.27.1 moves to Build Output v1 and @cloudflare/config 1.0.0-rc.0, but cf still pins @cloudflare/build-output-utils 0.9.14 and @cloudflare/config 0.32.1. That leaves two incompatible format versions in the shipped CLI.
Findings: 1 warning (1 is an inline comment on the diff)
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
🔧 Fix with your agent
Paste the following into your coding agent to investigate and fix these issues.
Fix the following code review issues found in pull request #637.
Before making changes, review each issue and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g., the fix would require disproportionate changes
for minimal ROI, or the finding is factually incorrect), explain why
- If you need to clarify something before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
## WARNING (1)
### [Code Quality] deploy-helpers 0.27.1 targets Build Output v1 and @cloudflare/config 1.0.0-rc.0, but cf still reads v0 output with build-output-utils 0.9.14 and config 0.32.1 and passes it to deploy-helpers. Preview deploys and other deploy paths may reject the config or read the account settings from the wrong place.
- **File:** packages/cli/package.json:87
📋 Code Quality: ⚠️ 1 warning
Build Output format version skew between deploy-helpers and the build-output-utils/config packages cf pins directly
Recommendation: 📝 Minor Comments
- [WARNING] deploy-helpers 0.27.1 targets Build Output v1 and @cloudflare/config 1.0.0-rc.0, but cf still reads v0 output with build-output-utils 0.9.14 and config 0.32.1 and passes it to deploy-helpers. Preview deploys and other deploy paths may reject the config or read the account settings from the wrong place. (
packages/cli/package.json:87)
View full review
The upgrade to @cloudflare/deploy-helpers 0.27.1 brings in @cloudflare/config@1.0.0-rc.0 (see pnpm-lock.yaml:4330-4333). In its changelog, 0.27.1 also says it writes Build Output v1 to .cloudflare/output/v1/, nests account settings under settings and reads preview account settings from that new location. cf itself still pins @cloudflare/build-output-utils 0.9.14 and @cloudflare/config 0.32.1 (packages/cli/package.json:72-73). Those versions read the v0 layout, which the tests use (.cloudflare/output/v0/...). cf reads the root config with the old reader and passes it straight to deploy-helpers. For example, src/commands/previews/deploy.ts:111-123 calls readBuildOutput, then assertPreviewBuildOutputRootConfig(output.rootConfig), using output.rootConfig.accountId at the top level.
✅ All other checks passed
🚀 Release: ✅ LGTM
Overall risk: Low. The dependency refresh comes with a "cf": patch changeset, and its versions match the package manifests.
🔒 Security: ✅ LGTM
No security concerns in these dependency bumps.
📖 AGENTS.md: ✅ LGTM
No AGENTS.md changes needed.
⚡ Performance: ✅ LGTM
No performance concerns.
📝 Documentation: ✅ LGTM
The changeset accurately lists the version changes.
Reviewed commit: 7bc3b5ba
| "@cloudflare/cli-shared-helpers": "0.3.9", | ||
| "@cloudflare/codemods": "0.8.0", | ||
| "@cloudflare/containers-shared": "0.26.2", | ||
| "@cloudflare/deploy-helpers": "0.27.1", |
There was a problem hiding this comment.
deploy-helpers 0.27.1 targets Build Output v1 and @cloudflare/config 1.0.0-rc.0, but cf still reads v0 output with build-output-utils 0.9.14 and config 0.32.1 and passes it to deploy-helpers. Preview deploys and other deploy paths may reject the config or read the account settings from the wrong place.
This bump brings in @cloudflare/config@1.0.0-rc.0 through deploy-helpers (pnpm-lock.yaml:4330-4333). Its changelog says it now writes and reads Build Output v1, with account settings nested under settings. cf still pins @cloudflare/build-output-utils 0.9.14 and @cloudflare/config 0.32.1 (lines 72-73). In src/commands/previews/deploy.ts:111-123, cf reads rootConfig with that old reader (top-level accountId) and hands it to assertPreviewBuildOutputRootConfig and the preview deploy from 0.27.1. Because deploy-helpers is bundled into the published CLI, preview deploys (and possibly other deploy paths) could fail or misread account settings. Consider upgrading @cloudflare/build-output-utils and @cloudflare/config to 1.0.0-rc.0 in this same pull request, and updating the v0 test fixtures, rather than shipping the two format versions side by side. Renovate's note says some dependencies could not be looked up, which may be why they were left out.
|
| mean | stddev | min | max | |
|---|---|---|---|---|
| PR | 297.0 ms | 5.4 ms | 286.9 ms | 303.7 ms |
| base | 293.0 ms | 4.1 ms | 288.0 ms | 302.5 ms |
Δ (PR vs base): ↑ +4.1 ms (+1.4%)
Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.
|
Review: 2 findings. Posted 2 inline findings on PR #637. |
|
Looks like most of these bumps are already incorporated in #540. I will ask renovate to check again once that is merged. |
This PR contains the following updates:
0.12.1→0.13.00.3.8→0.3.90.7.8→0.8.00.26.1→0.26.20.27.0→0.27.10.1.28→0.1.290.18.2→0.18.30.54.0→0.54.15.20261113.0-beta→5.20261116.0-betaWarning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
cloudflare/workers-sdk (@cloudflare/autoconfig)
v0.13.0Compare Source
Minor Changes
#16803
b219078Thanks @petebacondarwin! - Run experimental cf projects with their installed Vite or Vite+ commandscf dev,cf build, and deployments that build your project can use Vite or Vite+ even when no framework command is detected. This removes the need for the internalcf-vitedelegate and supports dependencies declared and hoisted at the root of a configured workspace. A workspace application using a custom-named Vite config should declare@cloudflare/vite-pluginin its own manifest, or addviteorvite-plusas a dependency or dev dependency to identify its tooling; this keeps shared root tools from selecting Vite for non-Vite siblings. Configs passed later via--configare evaluated by Vite when the command runs. Existing framework commands keep their priority. Consumers resolve bare executables using the detectednodeModulesPathsin order, adding.binto each directory. Lookup stops at the validated workspace root; standalone applications use only their ownnode_modules/.bin.Project inspection can recognize an existing Cloudflare configuration before dependencies are installed. Running a command provides guidance when the required tools are missing or the plugin version does not support cf profiles (
>=2.0.0-beta.v.13 <3). Vite evaluates the project configuration when the command runs, including dynamic configs and custom config files. Repair guidance uses the project’s detected package manager. Automatic setup asks users to convert CommonJS.cjsand.ctsVite configs to ESM imports and exports in.mjsor.mtsbefore adding the ESM-only Cloudflare plugin. Native builds also work with the Windows shell. Pages migration safeguards, unsupported-framework setup checks, and Wrangler command selection retain their existing behavior.Patch Changes
#16921
6785363Thanks @jamesopstad! - Install the Vite plugin release candidate when configuring projects forcfConfiguring a Vite project for
cfnow installs@cloudflare/vite-plugin@^2.0.0-rc.0instead of^2.0.0-beta.v.0, so an existing lockfile can't keep a beta that doesn't support the generated configuration.#16946
e97c9f8Thanks @dependabot! - UpdateDEFAULT_COMPAT_DATEto 2026-11-16Use the bundled workerd release's compatibility date by default when scaffolding new projects or when no compatibility date is configured.
Updated dependencies [
d36b39d,0bf81ac,e97c9f8,349fc4e]:cloudflare/workers-sdk (@cloudflare/cli-shared-helpers)
v0.3.9Compare Source
Patch Changes
#16946
e97c9f8Thanks @dependabot! - UpdateDEFAULT_COMPAT_DATEto 2026-11-16Use the bundled workerd release's compatibility date by default when scaffolding new projects or when no compatibility date is configured.
Updated dependencies [
e97c9f8,349fc4e]:cloudflare/workers-sdk (@cloudflare/codemods)
v0.8.0Compare Source
Minor Changes
#16246
349fc4eThanks @leostera! - Start local Workflows from Artifacts eventsDeclare Artifacts events on
exports.workflow({ name, events })incloudflare.config.tsto start the owning Workflow locally incf, Vite, and Workers Vitest. Wrangler configurations continue to usetriggers.events. Native config conversion derives those targets from the Workflow export, andcf migrateattaches existing event subscriptions to their matching Workflow exports.Local Artifacts namespaces publish the documented
cf.artifacts.*messages for repository create, import, fork, and delete operations and token creation and revocation. Successful create, import, and fork operations also publish the initial token-created event. Delivery follows the committed mutation, is unordered, and does not fail the repository operation if a destination rejects it. Push, clone, and fetch events are not yet published locally. This feature does not provide local Artifacts-to-queue subscriptions.Patch Changes
#16907
0bf81acThanks @jamesopstad! - Generate the release candidate@cloudflare/configfield names inwrangler-to-cfThe codemod now writes:
first_party_workerasexperimental.firstPartyWorkerbindings.pipeline({ streamId })bindings.k2({ id })bindings.analyticsSql()A Pipelines binding that uses the deprecated
pipelinefield gets aSTREAM_IDplaceholder and a follow-up asking for the stream ID, because that field names a legacy pipeline, which@cloudflare/configdoesn't support.#16921
6785363Thanks @jamesopstad! - Install the Vite plugin release candidate inwrangler-to-cfThe Wrangler-to-cf migration now installs
@cloudflare/vite-plugin@^2.0.0-rc.0instead of thebetadist tag, which no longer receives new releases. It upgrades projects whose plugin is declared as a dist tag or resolves to a version older than the release candidate, since earlier betas don't support the generated configuration. The range also covers the stable v2 releases, so the migration no longer rewritespackage.jsonto a dist tag after installing.#16946
e97c9f8Thanks @dependabot! - UpdateDEFAULT_COMPAT_DATEto 2026-11-16Use the bundled workerd release's compatibility date by default when scaffolding new projects or when no compatibility date is configured.
cloudflare/workers-sdk (@cloudflare/containers-shared)
v0.26.2Compare Source
Patch Changes
#16946
e97c9f8Thanks @dependabot! - UpdateDEFAULT_COMPAT_DATEto 2026-11-16Use the bundled workerd release's compatibility date by default when scaffolding new projects or when no compatibility date is configured.
Updated dependencies [
d36b39d,d36b39d,0bf81ac,e97c9f8,349fc4e]:cloudflare/workers-sdk (@cloudflare/deploy-helpers)
v0.27.1Compare Source
Patch Changes
#16917
d36b39dThanks @jamesopstad! - Write Build Output to.cloudflare/output/v1/and record the producervite buildand the experimentalwrangler build --experimental-cf-build-outputnow write Build Output v1, with account settings nested undersettingsin the rootconfig.json. They also record themselves as theproducer, so readers can name the tool that wrote the output in error messages. Previews from Build Output read the account settings from their new location.#16946
e97c9f8Thanks @dependabot! - UpdateDEFAULT_COMPAT_DATEto 2026-11-16Use the bundled workerd release's compatibility date by default when scaffolding new projects or when no compatibility date is configured.
Updated dependencies [
d36b39d,0bf81ac,e97c9f8,e97c9f8,349fc4e,0bf81ac]:cloudflare/workers-sdk (@cloudflare/runtime-types)
v0.1.29Compare Source
Patch Changes
#16946
e97c9f8Thanks @dependabot! - UpdateDEFAULT_COMPAT_DATEto 2026-11-16Use the bundled workerd release's compatibility date by default when scaffolding new projects or when no compatibility date is configured.
Updated dependencies [
e97c9f8,e97c9f8,349fc4e,0bf81ac]:cloudflare/workers-sdk (@cloudflare/workers-auth)
v0.18.3Compare Source
Patch Changes
#16946
e97c9f8Thanks @dependabot! - UpdateDEFAULT_COMPAT_DATEto 2026-11-16Use the bundled workerd release's compatibility date by default when scaffolding new projects or when no compatibility date is configured.
#16874
4335eacThanks @petebacondarwin! - Avoid redundant OAuth refreshes after a sibling process updates credentialsCheck access-token expiry and select the refresh token from the same fresh credential snapshot. When a sibling has already saved a valid access token, reuse it without another exchange or write. This prevents an unnecessary rotation that can let an older response overwrite a newer refresh token.
Updated dependencies [
e97c9f8,349fc4e]:cloudflare/workers-sdk (@cloudflare/workers-utils)
v0.54.1Compare Source
Patch Changes
#16946
e97c9f8Thanks @dependabot! - UpdateDEFAULT_COMPAT_DATEto 2026-11-16Use the bundled workerd release's compatibility date by default when scaffolding new projects or when no compatibility date is configured.
#16246
349fc4eThanks @leostera! - Start local Workflows from Artifacts eventsDeclare Artifacts events on
exports.workflow({ name, events })incloudflare.config.tsto start the owning Workflow locally incf, Vite, and Workers Vitest. Wrangler configurations continue to usetriggers.events. Native config conversion derives those targets from the Workflow export, andcf migrateattaches existing event subscriptions to their matching Workflow exports.Local Artifacts namespaces publish the documented
cf.artifacts.*messages for repository create, import, fork, and delete operations and token creation and revocation. Successful create, import, and fork operations also publish the initial token-created event. Delivery follows the committed mutation, is unordered, and does not fail the repository operation if a destination rejects it. Push, clone, and fetch events are not yet published locally. This feature does not provide local Artifacts-to-queue subscriptions.cloudflare/workers-sdk (miniflare)
v5.20261116.0-betaCompare Source
Minor Changes
#16246
349fc4eThanks @leostera! - Start local Workflows from Artifacts eventsDeclare Artifacts events on
exports.workflow({ name, events })incloudflare.config.tsto start the owning Workflow locally incf, Vite, and Workers Vitest. Wrangler configurations continue to usetriggers.events. Native config conversion derives those targets from the Workflow export, andcf migrateattaches existing event subscriptions to their matching Workflow exports.Local Artifacts namespaces publish the documented
cf.artifacts.*messages for repository create, import, fork, and delete operations and token creation and revocation. Successful create, import, and fork operations also publish the initial token-created event. Delivery follows the committed mutation, is unordered, and does not fail the repository operation if a destination rejects it. Push, clone, and fetch events are not yet published locally. This feature does not provide local Artifacts-to-queue subscriptions.#16907
0bf81acThanks @jamesopstad! - Rename the Pipelines, K2 and Analytics SQLenvbinding fields to match@cloudflare/configConfig-style
envbindings now use these shapes:{ type: "pipeline", streamId }instead of{ type: "pipeline", name }{ type: "k2", id }instead of{ type: "k2", stream }{ type: "analytics-sql" }instead of{ type: "analytics" }Patch Changes
#16946
e97c9f8Thanks @dependabot! - UpdateDEFAULT_COMPAT_DATEto 2026-11-16Use the bundled workerd release's compatibility date by default when scaffolding new projects or when no compatibility date is configured.
#16946
e97c9f8Thanks @dependabot! - Update dependencies of "miniflare", "wrangler"The following dependency versions have been updated:
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate CLI.