Repository navigation
Fix main: replace jsg::Number with f64 in jsg-test tests - #8074
nathanwhit wants to merge 1 commit into
Conversation
|
✅ Approved — This is a small test-only fix that removes the last uses of the deleted The decision is advisory: this comment never approves, blocks or requests changes on the pull request. ✅ All checks passed📋 Code Quality: ✅ LGTMThe change replaces
The tests were not built or run as part of this review. 📝 Documentation: ✅ LGTMThe changed test files contain no documentation or comment changes that need attention. Reviewed commit: |
|
LGTM! Reviewed commit: bf734db8 · github run |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8074 +/- ##
==========================================
- Coverage 69.49% 69.42% -0.07%
==========================================
Files 695 696 +1
Lines 181564 181749 +185
Branches 29204 29211 +7
==========================================
+ Hits 126170 126185 +15
- Misses 38328 38498 +170
Partials 17066 17066 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Fixed by #8072 |
Pull request was closed
#8045 added uses of jsg::Number in the resource_template and fast_api tests, which #8054 removed in favor of f64.