Skip to content

chore: remove default statusText from fetch test - #294

Merged
ryanking13 merged 2 commits into
mainfrom
gyeongjae/workerd-fetch-spec
Nov 4, 2026
Merged

ryanking13 merged 2 commits into
mainfrom
gyeongjae/workerd-fetch-spec

Conversation

@ryanking13

Copy link
Copy Markdown
Contributor

Following workerd change: cloudflare/workerd#7839

@ryanking13
ryanking13 requested review from dom96 and hoodmane November 3, 2026 05:13
@ask-bonk

ask-bonk Bot commented Nov 3, 2026

Copy link
Copy Markdown

LGTM

github run

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of 8629baaa.

This review, of 2aa83f73

✅ Approved — Trivial test-only change with no findings.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code reviewer: ✅ LGTM

No issues found.


Reviewed commit: 2aa83f73

@clanky-the-clanker clanky-the-clanker Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved — The test-only and test-tooling changes look correct, and I found no issues.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

I found no issues.

  • entrypoint.py: the default capture arguments are added before the forwarded pytest arguments in both run_pytest and run_suite, so a -s or --capture=... passed from the host still takes precedence.
  • test_ws_disconnect.py: the close listener is registered before the yield, so the test can't miss the server's close event.
  • test_sdk.py: the updated repr expectation matches the linked workerd change.

📝 Documentation: ✅ LGTM

The packages/testlib/AGENTS.md addition matches the code.


Reviewed commit: 8629baaa

@ryanking13
ryanking13 merged commit 52e4b26 into main Nov 4, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants