Skip to content

[create-cloudflare] Unquarantine experimental Waku E2E test - #16853

Merged
edmundhung merged 1 commit into
mainfrom
edmundhung/c3-unquarantine-experimental-waku
Nov 12, 2026
Merged

edmundhung merged 1 commit into
mainfrom
edmundhung/c3-unquarantine-experimental-waku

Conversation

@edmundhung

Copy link
Copy Markdown
Member

Reverts #16842 now that @cloudflare/vite-plugin@1.69.1 (#16841) is published as latest, which fixes waku build failing after static generation.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: this re-enables an existing E2E test.
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: test-only change.

@edmundhung edmundhung added the ci:no-changeset-required Skip pull request checks for a valid changeset label Nov 12, 2026
@changeset-bot

changeset-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b0f641f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ask-bonk

ask-bonk Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@pkg-pr-new

pkg-pr-new Bot commented Nov 12, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@16853

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@16853

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@16853

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@16853

@cloudflare/containers-shared

npm i https://pkg.pr.new/@cloudflare/containers-shared@16853

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@16853

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@16853

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@16853

miniflare

npm i https://pkg.pr.new/miniflare@16853

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@16853

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@16853

@cloudflare/runtime-types

npm i https://pkg.pr.new/@cloudflare/runtime-types@16853

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@16853

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@16853

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@16853

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@16853

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@16853

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@16853

wrangler

npm i https://pkg.pr.new/wrangler@16853

commit: b0f641f

@edmundhung
edmundhung marked this pull request as ready for review November 12, 2026 10:53
@workers-devprod
workers-devprod requested review from a team and cjol and removed request for a team November 12, 2026 10:54
@workers-devprod

workers-devprod commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@clanky-the-clanker clanky-the-clanker Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved — Test-only revert that re-enables an existing E2E test. No findings.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code reviewer: ✅ LGTM

The change only removes the quarantine flag and its TODO comment from the experimental Waku E2E entry.


Reviewed commit: b0f641f9

@edmundhung
edmundhung enabled auto-merge (squash) November 12, 2026 13:47

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Nov 12, 2026
@edmundhung
edmundhung merged commit c2d4ca4 into main Nov 12, 2026
97 of 101 checks passed
@edmundhung
edmundhung deleted the edmundhung/c3-unquarantine-experimental-waku branch November 12, 2026 15:54
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:no-changeset-required Skip pull request checks for a valid changeset

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants