Repository navigation
fix(miniflare): validate R2 S3 x-amz-checksum-* against body - #16948
umeraamir69 wants to merge 1 commit into
Conversation
Return BadDigest on mismatch for CRC32/CRC32C/SHA-1/SHA-256 (and NotImplemented for SHA checksums on UploadPart), matching real R2.
🦋 Changeset detectedLatest commit: c3aa613 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @umeraamir69. Thanks for taking the time to contribute to Workers SDK. This PR has been automatically closed because you are not currently a registered (vouched) collaborator for this repository. AI tools now let our team generate proposed code changes quickly. Reviewing changes, checking that they solve the right problem, and maintaining code quality over time still take substantial care and effort. We therefore limit PRs to registered collaborators so we can focus that effort where it is most useful. For the majority of external contributors, the most effective way to help is through issues: describing a problem or use case, providing a minimal reproduction, investigating its cause, or helping us verify a fix. Those contributions help us understand what needs to change and are very welcome. We will take an initial look at this PR and decide whether it is something we want to invest time in reviewing and maintaining. We may reopen it if we decide to proceed, but we cannot guarantee that it will be reopened or receive a full review. |
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
Fixes #16945.
The local R2 S3 endpoint ignored signed
x-amz-checksum-*headers while verifyingContent-MD5. PutObject/UploadPart now validate CRC32, CRC32C, SHA-1, and SHA-256 digests against the body and return400 BadDigeston mismatch. SHA-1 / SHA-256 on UploadPart return501 NotImplemented, matching real R2. CRC64NVME and checksum store/echo remain documented gaps.Test plan
vitest run test/plugins/r2/s3.spec.ts(87 passed)x-amz-checksum-sha256, SHA1/CRC32/CRC32C PutObject, SHA256 UploadPart → NotImplemented