Skip to content

[vite-plugin] Expose incoming email forwarding support in v1 - #16952

Draft
petebacondarwin wants to merge 1 commit into
codex/vite-v1-backport-16912from
codex/vite-v1-backport-16811
Draft

petebacondarwin wants to merge 1 commit into
codex/vite-v1-backport-16912from
codex/vite-v1-backport-16811

Conversation

@petebacondarwin

Copy link
Copy Markdown
Contributor

Backports #16811 to Vite plugin v1. The plugin forwards /cdn-cgi/local/email and its legacy alias to Miniflare with trigger handlers enabled. Incoming messages currently expose canBeForwarded as undefined; the upstream runtime fix makes it true, matching production.

Consume the fix through Miniflare 5.20261116.1-beta in the plugin, retained remote-bindings, and the direct runtime fixture. This is the intended version in open Version Packages #16950. No Wrangler upgrade is required for this Miniflare patch: #16929 already supplies Wrangler 4.163.0 and the compatible V4 adapter. #16944's Wrangler ConfigController watcher change is unrelated to the plugin's own configuration watching and is not backported.

Publication blocker — keep draft. The exact Miniflare version returns npm E404 and pnpm install --lockfile-only --ignore-scripts --no-frozen-lockfile fails on it. The lockfile remains the validated lower stack's pnpm-generated lockfile; no registry metadata is fabricated. After #16950 merges and publishes, verify its actual version, regenerate the lockfile, and run build, types and relevant plugin tests before marking ready.

A plugin patch changeset describes the local email behavior. No Miniflare source, upstream unit tests or removed fixtures are restored, and no installed Wrangler CLI tests are added. This consumes the original's tested runtime change through the existing plugin trigger-handler integration.

Native GitHub stack #16900, after #16940, rooted at vite-plugin-v1. Merge in stack order. Lower #16929/#16930 now have published dependencies and pass pnpm build, pnpm check (58 tasks) and pnpm test:ci (eight tasks, 269 plugin tests). The only new diff here is three consistent Miniflare pins and a plugin patch changeset. Changeset validation, pinned-dependency validation, action pinning, targeted formatting and git diff --check pass. Final build/types/tests with the intended dependency are blocked on npm publication; no passing upgrade test is claimed.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: the implementation is tested in the original Miniflare PR; this consumes its published dependency through the plugin's existing trigger handlers. Final dependency validation is blocked on npm publication.
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this restores a documented incoming-email property locally; the changeset describes the fix.

Note

This is a contribution from an AI agent: Codex.

@petebacondarwin petebacondarwin added the ci:no-tests Skip pull request checks for tests label Nov 16, 2026
@changeset-bot

changeset-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 29a4950

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin

Copy link
Copy Markdown
Contributor Author

@mindulle (original author) @edmundhung (human ant-core approver): please check this v1 backport of #16811 and approve it if it looks good.

V1 forwards local email trigger requests to Miniflare. This consumes the fix through consistent Miniflare pins and a plugin changeset; no dependency source or upstream tests are copied. #16929 already supplies the compatible Wrangler 4.163.0 adapter and lower dependency coverage. This remains draft because intended Miniflare 5.20261116.1-beta from open #16950 is not yet on npm; lockfile regeneration and final dependency validation must follow publication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:no-tests Skip pull request checks for tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant