Skip to content

nit: ignore linter error in fake - #492

Merged
aramprice merged 1 commit into
mainfrom
linter-fix
Oct 19, 2026
Merged

aramprice merged 1 commit into
mainfrom
linter-fix

Conversation

@aramprice

Copy link
Copy Markdown
Member

Fixes:

  Error: mbus/fakes/fake_handler.go:51:27: Error return value is not checked (errcheck)
  	h.RunCallBack = func() { <-block }
  	                         ^
  1 issues:
  * errcheck: 1

^ https://github.com/cloudfoundry/bosh-agent/actions/runs/39318953653/job/118287676841?pr=491

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 4a7c8a96-d64b-4d32-9338-68e898bef891
📥 Commits

Reviewing files that changed from the base of the PR and between 84ac244 and 5e2e7c7.

📒 Files selected for processing: 1
  • mbus/fakes/fake_handler.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The blocking receive callback in FakeHandler.KeepOnRunning now has an errcheck suppression comment. Runtime behavior is unchanged.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 5e2e7

This change only suppresses the warning for the intended blocking receive; no actionable merge risk was found.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description identifies the errcheck warning and provides a workflow link, but it omits the required sections for tests, release notes, breaking changes, team tags, and AI review feedback. Update the description with all template sections. State the tests run, release-note wording, whether the change is breaking, relevant team tags, contextual information, and AI review feedback resolution status.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the linter suppression change in the fake handler.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aramprice
aramprice merged commit e5585ff into main Oct 19, 2026
18 checks passed
@aramprice
aramprice deleted the linter-fix branch October 19, 2026 22:02
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants