Repository navigation
Stop running shutdown_drain with --disable-all - #698
Open
sethboyles wants to merge 1 commit into
Open
sethboyles wants to merge 1 commit into
sethboyles wants to merge 1 commit into
Conversation
The shutdown_drain scripts ran Ruby with --disable-all, which turns off RubyGems. In Ruby 4, logger moved from a default gem to a bundled gem, so `require 'cloud_controller/drain'` raised LoadError and CC, nginx and the workers were stopped without a graceful drain (drain.sh exits 0 regardless). ai-assisted=yes Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
philippthun
approved these changes
Sep 29, 2026
Samze
approved these changes
Sep 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shutdown_drain scripts ran Ruby with --disable-all, which turns off RubyGems. In Ruby 4, logger moved from a default gem to a bundled gem, so
require 'cloud_controller/drain'raised LoadError and CC, nginx and the workers were stopped without a graceful drain (drain.sh exits 0 regardless).This prevents the drain script from actually bringing down nginx. The error is swallowed by the drain script, so this does not block BBR, but removing
--disable-allwill correctly bring down the workers/CCNG.I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite