Repository navigation
Prevent expired-token replay on v3 upload endpoints - #5617
Merged
Merged
Conversation
The middleware read upload_start_time from Rack params, which merges query string and POST body. A client could supply a backdated value via query string (?upload_start_time=<past>) to shift the token-expiry reference time, allowing an expired token to pass auth on the v3 package, buildpack, and droplet upload endpoints. Additionally, a missing param caused nil.to_i == 0 which is truthy in Ruby, so the relaxed decoder was always constructed with reference time 0 (Unix epoch), accepting any token with exp > 0.
philippthun
reviewed
Nov 3, 2026
philippthun
approved these changes
Nov 3, 2026
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Nov 4, 2026
Changes in cloud_controller_ng:
- Prevent expired-token replay on v3 upload endpoints
PR: cloudfoundry/cloud_controller_ng#5617
Author: serdar özer <serdarozer14@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The middleware read upload_start_time from Rack params, which merges query string and POST body. A client could supply a backdated value via query string (?upload_start_time=) to shift the token-expiry reference time, allowing an expired token to pass auth on the v3 package, buildpack, and droplet upload endpoints.
Additionally, a missing param caused nil.to_i == 0 which is truthy in Ruby, so the relaxed decoder was always constructed with reference time 0 (Unix epoch), accepting any token with exp > 0.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests