Repository navigation
Adding a token for deploy-from-url LMCROSSITXSADEPLOY-3391 - #271
Open
s-yonkov-yonkov wants to merge 1 commit into
Open
s-yonkov-yonkov wants to merge 1 commit into
s-yonkov-yonkov wants to merge 1 commit into
Conversation
…nv var [LMCROSSITXSADEPLOY-3391] Thread a bearer token through the deploy-from-URL path so the controller can authenticate its outbound fetch against GitHub-protected URLs. Changes: - MtaClientOperations / MtaRestClient / RetryableMtaRestClient: StartUploadMtaArchiveFromUrl gains a `token string` parameter; the request body gains an optional `credentials.token` field (omitted when empty, so existing callers are unaffected) - deploy_command.go: register --url-token flag and MULTIAPPS_URL_TOKEN env var; flag overrides env var; token threaded through uploadFromUrl -> doUploadFromUrl -> StartUploadMtaArchiveFromUrl - Fakes updated to match new signature - Tests: 3 new Contexts covering flag, env-var fallback, and flag-over-env precedence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thread a bearer token through the deploy-from-URL path so the controller can authenticate its outbound fetch against GitHub-protected URLs.
Changes:
token stringparameter; the request body gains an optionalcredentials.tokenfield (omitted when empty, so existing callers are unaffected)