Repository navigation
Enable deploy from url with token - #1928
Open
s-yonkov-yonkov wants to merge 1 commit into
Open
s-yonkov-yonkov wants to merge 1 commit into
s-yonkov-yonkov wants to merge 1 commit into
Conversation
…ROSSITXSADEPLOY-3391] Add bearer token support to the deploy-from-URL feature so MTA archives hosted on GitHub (release assets, raw content) can be fetched using a GitHub PAT or GITHUB_TOKEN. Changes: - UserCredentials: add optional `token` field (additive, backward compatible) - Introduce RequestAuthenticator strategy (Bearer, Basic, UrlUserInfo, None) with explicit precedence: token > basic > url-userinfo > none - AuthenticatorResolver injected as a @nAmed Spring bean into DeployFromUrlRemoteClient (replaces inline if/else ladder) - Fix pre-existing audit-log leak: logStartUploadFromUrl now receives the userinfo-stripped URL instead of the raw decoded URL - Tests: AuthenticatorResolverTest (9), DeployFromUrlRemoteClientTest (+2), FilesApiServiceImplTest (+1 audit-log regression test) # Conflicts: # multiapps-controller-web/src/main/java/org/cloudfoundry/multiapps/controller/web/upload/client/DeployFromUrlRemoteClient.java # multiapps-controller-web/src/test/java/org/cloudfoundry/multiapps/controller/web/upload/client/DeployFromUrlRemoteClientTest.java
s-yonkov-yonkov
force-pushed
the
feature/LMCROSSITXSADEPLOY-3391
branch
from
October 16, 2026 13:36
a26345c to
e0c63ee
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.