Skip to content

chore: Resolve visual regression host from the PR head commit - #5211

Merged
jperals merged 2 commits into
mainfrom
fix/visual-regression-pr-host
Oct 30, 2026
Merged

jperals merged 2 commits into
mainfrom
fix/visual-regression-pr-host

Conversation

@jperals

@jperals jperals commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Description

The visual regression check currently takes the latest deployment of dev-pages-react18 to compare it against a local build from the latest main. But when multiple PRs are being raised concurrently, that could be a deployment from a different PR —especially if GitHub actions are running slowly.

For this reason, the first run of visual regression tests in #5207 came our green even though I was expecting diffs.

This change addresses this by using the PR's commit SHA to filter the deployments.

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.75%. Comparing base (025ddc4) to head (2dd1c5e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5211   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files        1003     1003           
  Lines       32539    32539           
  Branches    12085    12084    -1     
=======================================
  Hits        31810    31810           
- Misses        684      723   +39     
+ Partials       45        6   -39     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jperals
jperals added this pull request to the merge queue Oct 30, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 30, 2026
@jperals
jperals added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit 34956d5 Oct 30, 2026
69 checks passed
@jperals
jperals deleted the fix/visual-regression-pr-host branch October 30, 2026 13:12

This branch was successfully deployed

3 active deployments
dev-pages-react18 — 2dd1c5e6 Deployed Oct 30, 2026 by jperals via deploy (React 18) / deploy #3055
dev-pages-react16 — 2dd1c5e6 Deployed Oct 30, 2026 by jperals via deploy (React 16) / deploy #3055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants