Fix #1630: set TOWER_TEST_PORT in the scheduled dashboard e2e workflow - #1632
Open
amrmelsayed wants to merge 1 commit into
Open
Fix #1630: set TOWER_TEST_PORT in the scheduled dashboard e2e workflow#1632amrmelsayed wants to merge 1 commit into
amrmelsayed wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One env line: the scheduled Dashboard E2E run has been red since PR #1604 landed its live-Tower guard (the test refuses to default to port 4100). CI never had TOWER_TEST_PORT set, so the guard trips. Sets it to 14100, matching the guard's own suggestion. The playwright.config 4100 default remains a flagged follow-up in #1630 (needs per-test default sync). Fixes #1630.