Skip to content

italy_yaml fix loading datetimes - #1724

Merged
prandla merged 1 commit into
cms-dev:mainfrom
prandla:yamlfix
Sep 26, 2026
Merged

prandla merged 1 commit into
cms-dev:mainfrom
prandla:yamlfix

Conversation

@prandla

@prandla prandla commented Sep 26, 2026

Copy link
Copy Markdown
Member

parse_datetime is already called in make_group, so we mustn't use it with main_group options. (otherwise we will call parse_datetime or make_timedelta twice, which is incorrect. this caused me a very infuriating debug session because i thought my fix for #1565 was somehow buggy.)

parse_datetime is already called in make_group, so we mustn't use it
with main_group options. (otherwise we will call parse_datetime or
make_timedelta twice, which is incorrect. this caused me a very
infuriating debug session because i thought my fix for cms-dev#1565 was somehow
buggy.)
@prandla
prandla requested a review from veluca93 September 26, 2026 14:33
@codecov

codecov Bot commented Sep 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.71%. Comparing base (c76c40d) to head (10cb28c).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
cmscontrib/loaders/italy_yaml.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1724      +/-   ##
==========================================
- Coverage   56.71%   56.71%   -0.01%     
==========================================
  Files         344      344              
  Lines       28307    28307              
==========================================
- Hits        16055    16054       -1     
- Misses      12252    12253       +1     
Flag Coverage Δ
functionaltests 0.00% <0.00%> (ø)
unittests 56.71% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@prandla
prandla merged commit cc9dfaf into cms-dev:main Sep 26, 2026
3 of 4 checks passed
@prandla
prandla deleted the yamlfix branch September 26, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants