Give the integration test poll fifteen seconds by default - #77
Merged
windischb merged 1 commit intoSep 5, 2026
Merged
Conversation
The cancellation-timing tests timed out at five seconds twice within a day on the develop and release runners, which execute the suite for three target frameworks in one job alongside the Docker-backed backplane tests -- and passed for the other frameworks in the same job each time. The second occurrence blocked the 5.1.0 release until a rerun. A slow arrival is still an arrival; the timeout exists for the case where it never comes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CancellationTokenTests.ServerCancelsClientCancellationToken_ClientReceivesCancellationtimed out at 5 s on the 5.1.0 release run (ubuntu), passing for the other two target frameworks in the same job;CancellationBindingTestsdid the same the day before. The ubuntu job runs all three frameworks plus the Docker-backed backplane tests on one runner. The release needed a manual rerun.What
TestHelper.WaitFordefaults to 300 attempts × 50 ms (15 s) instead of 100. Only a failing condition takes longer to fail; a passing one returns as soon as it holds. The explicitattempts: 300added yesterday to one test is now the default for all of them.🤖 Generated with Claude Code