Fix the 5.2.0-beta.1 findings: Npgsql floor, ConnectionBoundSchemes builder, CS0436 - #82
Merged
Merged
Conversation
The Postgres backplane is built against Npgsql 8.0.6 on every target framework, so the package asks for Npgsql >= 8.0.6 instead of the newest version per framework; a net10.0 application on Npgsql 9 (Marten) can add it without NU1605. WithConnectionBoundSchemes(...) on SignalARRRServerOptionsBuilder: the list lived on the options, but AddSignalARRR hands out the builder, so the documented example did not compile. The generator leaves out a referenced contract whose proxy the referenced assembly already contains and that is visible here, instead of generating a second copy that clashes with it (CS0436) in test projects with the API's InternalsVisibleTo. Tests.SharedModels now grants InternalsVisibleTo to the integration tests, which breaks the build without the fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
amZettel tested 5.2.0-beta.1 on all clients and reported three findings. One of them blocks it: the Postgres backplane.
What
1. Postgres backplane demanded Npgsql 10 on net10.0 (blocking)
NU1605.VersionOverride). The nuspec asks forNpgsql >= 8.0.6in all three groups. The code only needsNpgsqlDataSourceandLISTEN/NOTIFY.2.
ConnectionBoundSchemesunreachable from the options builderAddSignalARRRhands out the builder, which had no way to reach the list, so the documentedoptions.ConnectionBoundSchemes.Add(...)did not compile.WithConnectionBoundSchemes(params string[]). It de-duplicates names and rejects empty ones. The authorization guide uses it.3. CS0436 in test projects with the API's
InternalsVisibleToInternalsVisibleTo.Verification
Tests.SharedModelsnow grantsInternalsVisibleToto the integration tests. Without the generator fix that build fails with three CS0436 errors; with the fix it is clean.🤖 Generated with Claude Code