You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up to #91 (merged as #102 and #105). The review rounds on #105 raised these five points. Each is a design decision, so none was changed there.
Decisions needed
Plan approvals.start does not check that the plan's items were approved. Should running a plan require approval of the plan, or of each item, first?
Review version.start and resume check the task's state version but not the plan's review_version. AGENTS.md says an action that owns several version counters must require all of them unchanged. Should these actions take expectedReviewVersion?
Requeue claim. When resume acts on an owed finding or pause instead of admitting an item, the task moves to needs human with requeue_pending still set. runner-lifecycle.md says exactly one path (I3's requeue or the user's Resume) clears it. Should that settled path clear it too?
Owed work before the F2: continue a task after a scope pause (reconcile the prefix, validate the rest) #88 refusals. A safety finding held only in memory (its durable save failed) is not acted on when runChoice refuses first: scope pause, revised plan with earlier commits, active merge, pending cancel. A restart loses such a finding either way. Should begin act on owed work before those refusals?
Earlier commits across runs.resume continues from the first item with no completed attempt at the current revision. It does not check that the commits of items completed in earlier runs are still in the task head (for example, after the head moved). Should resume verify the executed prefix against the head, as plan-format.md's reconciliation (F2: continue a task after a scope pause (reconcile the prefix, validate the rest) #88) does?
Where
web/server.ts (runChoice, the start and resume actions), runner/execution.ts (ItemExecutor.begin, progress), runner/store.ts (admitAttempt, executeProgress), and docs/implementation/runner-lifecycle.md ("Start and resume (#91 part 2)").
Activity