Skip to content

Future Windows support: use platform-aware clone path containment #36

Description

@mchwang

PR #31 review round 2 returned Findings: None, but its overview raised Windows path-boundary rejection. Reproduced the intermediate path with node:path.win32: relative(C:\repo, C:\tasks) is ..\tasks; the POSIX ../ prefix test treats it as inside and rejects valid sibling task storage.

Windows support is explicitly excluded by docs/designs/codeboost-plan-indexed-review.md (Out of scope: container/sign-in design checked for macOS and Linux only). This is deferred future-platform work, not a blocker for D1 on supported platforms.

Before enabling Windows, use platform-aware separators and add Windows drive, UNC, case/alias, and junction containment fixtures. Verify valid sibling directories are accepted and nested or aliased source/metadata storage is rejected. Do not claim Windows isolation from a lexical-only test. Scope: git/clone.ts containment predicate and dedicated fixtures.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions