Repository navigation
Conversation
|
Hi there, @MohamedRF! 👋 Thank you for sending this PR! We expect the following in all Pull Requests (PRs).
Important We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works. If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md |
paulbalandan
reviewed
Nov 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Running
.github/scripts/run-random-tests.sh --max-jobs 1hangs before starting PHPUnit. When no child processes remain,cleanup_finished_pids()assigns("${active[@]:-}"), creating an array with one empty element. The scheduler counts that element as an active job and waits indefinitely.Keep the process list empty when there are no active PIDs. Add
RunRandomTestsTesttotests/system/AutoReview/, following the existing script-test convention. Each case builds an isolated temporary project with two stub components and calls the runner throughexec(), checking its exit code, success output, and two executions per component. The data provider covers job limits of one and two. A five-secondtimeoutwith a one-second kill grace prevents a regression from hanging PHPUnit; the temporary project is removed in teardown. The existing AutoReview workflow discovers the test without workflow changes.Refs #9968. This fixes the runner rather than completing the component migration tracked by that issue.
Validation
vendor/bin/phpunit tests/system/AutoReview/RunRandomTestsTest.php --no-coverage: 2 tests, 12 assertions pass.git diff --checkpasses.Checklist: