Repository navigation
Conversation
paulbalandan
approved these changes
Nov 5, 2026
neznaika0
approved these changes
Nov 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reset shared services in
SecurityHelperTest::setUp()so it does not reuse a request or security mock left by another helper test. With random seed1793892530,SiteUrlCliTestruns first and leaves aCLIRequestin the shared request service. ConstructingMockSecuritylater fails becauseSecurity::$requestrequires anIncomingRequest.Enable Helpers in the random-test configuration after verifying the component with the failing seed and repeated randomized runs. This completes the Helpers component of #9968; the overall issue remains open for other components.
Validation
vendor/bin/phpunit tests/system/Helpers --order-by=random --random-order-seed=1793892530 --no-coveragefails with aCLIRequest/IncomingRequestTypeError..github/scripts/run-random-tests.sh --component Helpers --repeat 10 --max-jobs 2 --quietpass.git diff --checkpasses.Tested with PHP 8.5.12 / PHPUnit 11.5.57 on macOS. The full platform matrix is left to CI.
Checklist: